-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Address Security Vulnerabilities and Framework Enhancements #160
Conversation
Look like I need to update the node version to node 18 |
I see you added the "On Staging" label, I'll get this merged to the staging branch! |
Merge conflict attempting to merge this into staging. Please fix manually. |
@caleballdrin I have assigned this to you as you have worked on this before, but just let me know if I also need to get Caleb Cox or Daniel Frett. |
Merge conflict attempting to merge this into staging. Please fix manually. |
@dr-bizz any reason that there is both a But my js knowledge is limited, so there very well could be a good reason I don't know |
We can remove the |
@dr-bizz I think it was the other way, we had yarn.lock before and the package-lock.json is the new one :) |
Sorry, I just saw that. |
…d of it. It pretty much tells the router a different way to find pages when the route is "../slibing". Removing it makes it work as expected. Plus we don't have any routes where we use ../ in the route name.
…ser. Updating angular.json and TS settings to new work with the Angular 17 and the TS 5.2.2.
f64f61c
to
9e563db
Compare
Description
This PR addresses multiple security issues flagged by npm and Dependabot, involving major version upgrades and code adjustments.
Major Fixes
Key Adjustments:
Polyfills: Updated polyfills.ts to support core-js@3 with es module imports, ensuring compatibility with newer Angular configurations.
Testing Enhancements: Resolved issues in test.ts related to outdated configurations, enabling Karma to find all test files without manual imports.
Command Optimization: Added --watch=false to ng test due to recurring errors in watch mode. Other users also had this error, I followed their instructions to update packages, but after that didn't work, I ended up with this fix.
IE11 Support Removal: Removed support for Internet Explorer 11, as it is deprecated and unsupported by core-js@3.
Minor Changes:
Updated Angular.json Properties: Refactored to use updated Angular properties for improved build configurations.
TypeScript Target: Set target to ES2022 for enhanced compatibility with modern JavaScript standards.