Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Address Security Vulnerabilities and Framework Enhancements #160

Merged
merged 8 commits into from
Nov 6, 2024

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Nov 1, 2024

Description

This PR addresses multiple security issues flagged by npm and Dependabot, involving major version upgrades and code adjustments.

Major Fixes

  • Angular: Upgraded from v13 to v17 to maintain security and compatibility.
  • TypeScript: Updated from v4 to v5.2.2 to align with Angular 17 requirements.
  • core-js: Migrated from v2 to v3, updating all references to use modern es modules instead of deprecated es6 paths.

Key Adjustments:

Polyfills: Updated polyfills.ts to support core-js@3 with es module imports, ensuring compatibility with newer Angular configurations.
Testing Enhancements: Resolved issues in test.ts related to outdated configurations, enabling Karma to find all test files without manual imports.
Command Optimization: Added --watch=false to ng test due to recurring errors in watch mode. Other users also had this error, I followed their instructions to update packages, but after that didn't work, I ended up with this fix.
IE11 Support Removal: Removed support for Internet Explorer 11, as it is deprecated and unsupported by core-js@3.

Minor Changes:

Updated Angular.json Properties: Refactored to use updated Angular properties for improved build configurations.
TypeScript Target: Set target to ES2022 for enhanced compatibility with modern JavaScript standards.

@dr-bizz dr-bizz changed the title Security patches Security Patches Nov 1, 2024
@dr-bizz dr-bizz changed the title Security Patches Fix Security Vulnerabilities Nov 1, 2024
@dr-bizz dr-bizz changed the title Fix Security Vulnerabilities Update to Address Security Vulnerabilities and Framework Enhancements Nov 1, 2024
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Nov 1, 2024

Look like I need to update the node version to node 18

@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Nov 4, 2024
Copy link
Contributor

I see you added the "On Staging" label, I'll get this merged to the staging branch!

Copy link
Contributor

Merge conflict attempting to merge this into staging. Please fix manually.

@dr-bizz dr-bizz requested a review from caleballdrin November 4, 2024 14:15
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Nov 4, 2024

@caleballdrin I have assigned this to you as you have worked on this before, but just let me know if I also need to get Caleb Cox or Daniel Frett.

Copy link
Contributor

Merge conflict attempting to merge this into staging. Please fix manually.

@dr-bizz dr-bizz requested a review from frett November 4, 2024 15:46
.github/workflows/node.js.yml Outdated Show resolved Hide resolved
@frett
Copy link
Contributor

frett commented Nov 4, 2024

@dr-bizz any reason that there is both a package-lock.json and yarn.lock file? I'd assume we probably only want to use one package manager and not both.

But my js knowledge is limited, so there very well could be a good reason I don't know

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Nov 4, 2024

@dr-bizz any reason that there is both a package-lock.json and yarn.lock file? I'd assume we probably only want to use one package manager and not both.

But my js knowledge is limited, so there very well could be a good reason I don't know

We can remove the yarn.lock, I added that by mistake.

@frett
Copy link
Contributor

frett commented Nov 4, 2024

@dr-bizz I think it was the other way, we had yarn.lock before and the package-lock.json is the new one :)

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Nov 4, 2024

Sorry, I just saw that.

@dr-bizz dr-bizz merged commit 5ec6997 into master Nov 6, 2024
4 checks passed
@dr-bizz dr-bizz deleted the security-patches branch November 6, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants