ATM_challenge_nov_2021 #33

Mljungho · 2021-11-12T17:26:39Z

[PR-ATM challenge]

PR content
In this PR me and Giovanni are submitting the ATM challenge

This PR contains

Added testing scenarios for ATM and basic logic response depending on situation, and implementation.
Added person, atm & account class.
Added person, atm & account specs.

What I have learned

Make better use of .class function & methods.
Further improve on the spec functionality
How to utilize double instances & instance variables between classes.
Process of pair programming & submitting

Installed rspec

creating atm class

Adding implementation for withdraw

insufficient funds in account methods adding preform transaction method fixing method calls inside spec-file

adding implementation code

…pin?' condition in atm.rb file. Added pincode '1234' for test argument -> 'atm_spec.rb'. added pincode for every condition and test passes. Added condition for incorrect pin and povides correct message. Removed all comments on 'spec_helper.rb'

…2021

…ator 5, 10, 20$ bills. Added logic to handle these denominations.

unit test to check pin_code length, expiery date, account status initialized :active, deactivate method

…, adding implementation in Account class

testing Person name initialization, error raise if no name defined, cash attribute initialized, account attribute, account creation method creating Person class with all implementation for the mentioned tests minor code cleaning

…e have not created an account

…nto deposit method and implementing

adding implementation

…nt funds in Atm adding implementation in Person class

…y denominator and implementation

adding unit test to raise an error if the withdraw method has been called without a pin in the person_spec.rb

test removed - 'is expected to reduce funds on withdraw'

Added headlines: The Code Dependencies Setup Instructions Updates/Improvment Plans

…ion successful

… using another one added unit test to check if the account balance is insufficient adding implementation in person.rb

Adding MIT License

Mljungho and others added 30 commits November 8, 2021 16:55

basic project structure.

d010d7e

Installed rspec

Adding unit test for atm class instantiation

cb96aea

creating atm class

Adding unit test for witdrawal.

c3cc588

Adding implementation for withdraw

added unit test for withdrawal with enough balance.

921c398

Added implementation for withraw account

957c4ac

insufficient funds in account methods adding preform transaction method fixing method calls inside spec-file

Adding unit test for withdrawal bigger amount than available funds

8e3ef61

adding implementation code

Adding unit test for withdrawal bigger amount than ATM available funds

0f6ed0c

Adding implementation for insufficient funds in atm condition

33d72bc

WIP unit test failing

8c3313b

Fixing card expire unit test

fcac599

Added unit test with account status disabled and implementation

f0966a6

Added unit test with account status disabled and implementation

c4272f3

Merge branch 'master' of https://github.com/giacoletti/atm_challenge_…

0901555

…2021

Added bills to withdrawal unit test and implementation. Added demonin…

07ed442

…ator 5, 10, 20$ bills. Added logic to handle these denominations.

Creating account Class and adding unit test for the account class.

c4a679b

unit test to check pin_code length, expiery date, account status initialized :active, deactivate method

Added instance doubble Person, added unit test - Ownership of account…

ac0ce73

…, adding implementation in Account class

Adding unit tests for Person class

f9c3d40

testing Person name initialization, error raise if no name defined, cash attribute initialized, account attribute, account creation method creating Person class with all implementation for the mentioned tests minor code cleaning

Adding implementation to raise error if trying to do a deposit when w…

f63993b

…e have not created an account

added unit test to add funds to the account balance and deduct cash i…

d560c03

…nto deposit method and implementing

added unit test for withdraw funds method. Unit test failing

7e392ce

Adding unit tests for withdrawal method of Person class

6e35aec

adding implementation

Adding unit test to raise error if trying to withdraw with insufficie…

c415f5d

…nt funds in Atm adding implementation in Person class

Added unit test checking if withdrawal amount is divisible by currenc…

19079e7

…y denominator and implementation

Code refactoring of Person class (WIP)

f9299ce

adding unit test to raise an error if the withdraw method has been called without a pin in the person_spec.rb

removed duplicated unit test in atm_spec

d7adb94

test removed - 'is expected to reduce funds on withdraw'

Wrote documentation README.md WIP

0ba51b3

Added headlines: The Code Dependencies Setup Instructions Updates/Improvment Plans

Adjusted the syntax block and added ruby code format

03f5d82

Adjusted Ruby code blocks for the README.md WIP

a6df40a

adjusted ruby codeformat to include the syntax response

0ef0e66

Mljungho and others added 9 commits November 12, 2021 17:50

Adjusting the blocks of code and Ruby code formater

957a728

testing .md functions

6e23ce3

Code refactoring for unit tests of Person class for withdrawal operat…

c3dfb86

…ion successful

Code refactoring - Person class, using Atm withdraw method instead of…

0910374

… using another one added unit test to check if the account balance is insufficient adding implementation in person.rb

Fixing tip of current branch - not aligned

675560d

Formatting all ruby files using Rufo

3fb1fa5

Creating LICENSE.txt

9d0b575

Adding MIT License

Adding license to README.md

606f7a2

Fixing MIT License link in README.md

9b4259a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ATM_challenge_nov_2021 #33

ATM_challenge_nov_2021 #33

Mljungho commented Nov 12, 2021

ATM_challenge_nov_2021 #33

Are you sure you want to change the base?

ATM_challenge_nov_2021 #33

Conversation

Mljungho commented Nov 12, 2021

[PR-ATM challenge]