ATM, Janko, Blake and Jaime #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding atm class, initializing $
Added a test on rspec that tests the withdrawal
…fix before next push
… working to pass test
faraznaeem
approved these changes
Feb 20, 2020
| end | ||
|
|
||
| def self.deactivate(account) | ||
| account.account_status = :deactivated |
There was a problem hiding this comment.
Why did you guys use a class method here?
|
|
||
| def missing_owner | ||
| raise "An Account owner is required" | ||
| end |
There was a problem hiding this comment.
make sure that you are using the proper indentation
|
|
||
| when account_disabled?(account.account_status) | ||
| {status: false, message: 'account is disabled', date: Date.today} | ||
|
|
There was a problem hiding this comment.
no need for extra lines
| # This file was generated by the `rspec --init` command. Conventionally, all | ||
| # specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`. | ||
| # The generated `.rspec` file contains `--require spec_helper` which will cause | ||
| # this file to always be loaded, without a need to explicitly require it in any |
There was a problem hiding this comment.
always clean out comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM Challenge
https://github.com/JaimeCrz/atm_challenge_2019
PR Content.
In this PR we are creating an ATM.
This PR contains:
What we have learned.