[FIX] i think i fixed #8 for windows but it isn't fixed for linux + […

…FIX] fixing test
Cr0a3 · Aug 27, 2024 · f27cfe7 · f27cfe7
1 parent 854ed8a
commit f27cfe7
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 7 deletions.
diff --git a/src/Obj/wrapper.rs b/src/Obj/wrapper.rs
@@ -172,7 +172,7 @@ impl ObjectBuilder {
         let secData = obj.add_section(vec![], ".data".as_bytes().to_vec(), SectionKind::Data);
         let secConsts = obj.add_section(vec![], ".rodata".as_bytes().to_vec(), SectionKind::ReadOnlyData);
 
-        let mut syms: BTreeMap<String, (Option<SectionId>, Option</*offsest*/u64>, SymbolId)> = BTreeMap::new();
+        let mut syms: BTreeMap<String, (Option<SectionId>, Option</*offsest*/u64>, SymbolId, Decl)> = BTreeMap::new();
 
         for (name, data) in &self.defines {
             let name = name.to_owned();
@@ -247,21 +247,25 @@ impl ObjectBuilder {
                     Decl::Constant => obj.add_symbol_data(sym, secConsts, &data, align),
                 };
 
-                syms.insert(name.clone(), (None, Some(def_offset), sym));
+                syms.insert(name.clone(), (None, Some(def_offset), sym, *decl));
             } else {
-                syms.insert(name.clone(), (None, None, sym));
+                syms.insert(name.clone(), (None, None, sym, *decl));
             }
         }
 
         for link in &self.links {
-            let (_, off, _) = syms.get(&link.from).unwrap();
-            let (_, _, to_sym) = syms.get(&link.to).unwrap();
+            let (_, off, _, _) = syms.get(&link.from).unwrap();
+            let (_, _, to_sym, ty) = syms.get(&link.to).unwrap();
 
             let mut addend = 0;
             let mut offset = 0;
 
             if self.triple.getCallConv() == Ok(CallConv::WindowsFastCall) {
-                addend = -1;
+                addend = match ty {
+                    Decl::Function => 0,
+                    Decl::Data => -1,
+                    Decl::Constant => -1,
+                };
                 offset = -4;
             } else if self.triple.getCallConv() == Ok(CallConv::SystemV) {
                 addend = 0;

diff --git a/src/Target/target_descr.rs b/src/Target/target_descr.rs
@@ -68,7 +68,7 @@ impl BackendInfos {
 
         for (var, store) in &self.varsStorage {
             if let VarStorage::Register(var_reg) = store {
-                if var_reg == &reg {
+                if var_reg.sub64() == reg.sub64() {
                     out = Some(var);
                 }
             }

diff --git a/tests/x64_instruction_encoding.rs b/tests/x64_instruction_encoding.rs
@@ -29,12 +29,14 @@ pub fn test_ret() {
 #[test]
 pub fn test_optimization() {
     let mut instrs = vec![
+        Instr::with0(Mnemonic::StartOptimization),
         Instr::with2(Mnemonic::Mov, Operand::Reg(x64Reg::Rax.boxed()), Operand::Reg(x64Reg::Rcx.boxed())),
         Instr::with2(Mnemonic::Add, Operand::Reg(x64Reg::Rax.boxed()), Operand::Reg(x64Reg::Rdx.boxed())),
         Instr::with2(Mnemonic::Mov, Operand::Reg(x64Reg::Rcx.boxed()), Operand::Reg(x64Reg::Rax.boxed())),
     ];
 
     let expected_optimized = vec![
+        Instr::with0(Mnemonic::StartOptimization),
         Instr::with2(Mnemonic::Lea, Operand::Reg(x64Reg::Rax.boxed()), Operand::Mem(x64Reg::Rcx + x64Reg::Rdx)),
         Instr::with2(Mnemonic::Mov, Operand::Reg(x64Reg::Rcx.boxed()), Operand::Reg(x64Reg::Rax.boxed())),
     ];