Added tasks to construct aero_diffparm.yaml from template. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoryMartin-NOAA
commented
Jun 4, 2024
| @@ -25,6 +25,7 @@ def __init__(self, config: Dict[str, Any]) -> None: | |||
| _res_anl = int(self.config['CASE_ANL'][1:]) | |||
|
|
|||
| _bmat_yaml = os.path.join(self.runtime_config.DATA, f"{self.runtime_config.CDUMP}.t{self.runtime_config['cyc']:02d}z.chem_diagb.yaml") | |||
| _diff_yaml = os.path.join(self.runtime_config.DATA, f"{self.runtime_config.CDUMP}.t{self.runtime_config['cyc']:02d}z.chem_diff.yaml") | |||
There was a problem hiding this comment.
can you change all of these from diff (and DIFF) to diffusion (DIFFUSION) just to be more explicit, and not make people think it is 'difference'
CoryMartin-NOAA
commented
Jun 4, 2024
ush/python/pygfs/task/bmatrix.py
Outdated
| logger.info(f"Generate B Matrix YAML config: {self.task_config.bmat_yaml}") | ||
| bmat_config = parse_j2yaml(self.task_config.BMATYAML, self.task_config, searchpath=self.gdasapp_j2tmpl_dir) | ||
| logger.debug(f"BMAT config:\n{pformat(bmat_config)}") | ||
|
|
||
| return bmat_config | ||
| return bmat_config |
There was a problem hiding this comment.
remove the trailing whitespace here, it's causing coding norms to fail
|
@andytangborn can you fix the suggestions otherwise I can tomorrow |
|
Sure, I can do it.
…On Tue, Jun 4, 2024 at 4:42 PM Cory Martin ***@***.***> wrote:
@andytangborn <https://github.com/andytangborn> can you fix the
suggestions otherwise I can tomorrow
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ARAAHYMV2RMWBXLBDFI2KTTZFYRDJAVCNFSM6AAAAABIYXGAZ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGM4DENJTGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I made the changes. git push didn't do anything (??). We can discuss in the morning. |
|
Oh sorry, one more step needed. |
CoryMartin-NOAA
commented
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Change characteristics
How has this been tested?
Checklist