add a button and confirmation to delete the private key #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
something to consider: make this feature opt-out rather than opt-in. Security by default |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very neat project and idea, thanks for publishing it!
I noticed that there wasn't an easy way to "cleanup" after the user is done with the secret. I tinkered for a little bit and added a delete key button and confirmation afterward to hopefully avoid accidental deletion.
confirmation:
If there is interest in having this feature, I am open to feedback regarding the code. Vue and JS more generally are not my forte, I tried to keep it simple but perhaps there are better ways.
I also understand if there isn't interest in having the feature. We can close the PR if that is the case. Partially I was just interested in learning how it works and seeing if I could manage to add this functionality.