Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity issue #71

Merged
merged 5 commits into from
Oct 21, 2023
Merged

Activity issue #71

merged 5 commits into from
Oct 21, 2023

Conversation

johan-t
Copy link
Contributor

@johan-t johan-t commented Oct 15, 2023

Fix: #69

The best Match now gets 24h to respond to the message if the best match does not write a message into the textChannel their match will be terminated and the user will get a new match, whilst the bestMatch will be deleted from the DB to prevent it from happening again.

@KoTenshi
Copy link
Contributor

  1. The 'bestMatchSentMessage' variable isn't user-specific meaning that matches would interfere with each other

  2. using setTimeout doesn't work if the bot restarts

I have not tested if the code itself works but these are two issues i saw.

@TheLlamamarketer
Copy link
Contributor

shouldn't we merge this branch into preproduction branch and not into main?

@johan-t
Copy link
Contributor Author

johan-t commented Oct 16, 2023

shouldn't we merge this branch into preproduction branch and not into main?

I think it is fine, we just need to remember to merge 'main' into 'development' before opening a new branch

@johan-t
Copy link
Contributor Author

johan-t commented Oct 16, 2023

  1. The 'bestMatchSentMessage' variable isn't user-specific meaning that matches would interfere with each other
  2. using setTimeout doesn't work if the bot restarts

I have not tested if the code itself works but these are two issues i saw.

Good catch, I did not think about this will fix

@johan-t johan-t mentioned this pull request Oct 18, 2023
@TheLlamamarketer TheLlamamarketer merged commit 48879c0 into main Oct 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Match people based on activity score.
3 participants