Fixing the issue that users can react to old questions #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg6775
reviewed
Oct 6, 2023
| @@ -108,7 +110,7 @@ export const sendTestButton = async () => { | |||
| const guild: Guild | undefined = client.guilds.cache.get(guildId); | |||
| if (!guild) throw new Error('Guild not found'); | |||
|
|
|||
| (guild.channels.cache.get("1135557183845711983") as TextChannel).send({ components: [actionRow] }); // Channel Id for #How-to-basics | |||
| (guild.channels.cache.get("1135557183845711983") as TextChannel).send({ components: [actionRow] }); // Channel Id for #How-to-basics; main sever: 1135557183845711983; test sever: 1159905209414332526 | |||
There was a problem hiding this comment.
Suggested change
| (guild.channels.cache.get("1135557183845711983") as TextChannel).send({ components: [actionRow] }); // Channel Id for #How-to-basics; main sever: 1135557183845711983; test sever: 1159905209414332526 | |
| (guild.channels.cache.get("1135557183845711983") as TextChannel).send({ components: [actionRow] }); // Channel Id for #How-to-basics; main server: 1135557183845711983; test server: 1159905209414332526 |
greg6775
reviewed
Oct 6, 2023
| @@ -44,6 +44,8 @@ const questions = [ | |||
| { question: 'Unternehmen sollen selbst entscheiden, ob sie ihren Beschäftigten das Arbeiten im Homeoffice erlauben.', tag: ['Arbeitsrecht', 'Digitalisierung'] }, | |||
| ]; | |||
|
|
|||
| const specificQuestionMessage = {} as { [key: string]: any} | |||
There was a problem hiding this comment.
this object is only stored in heap. therefore, it'd reset every time the bot re-deploys
greg6775
reviewed
Oct 6, 2023
| @@ -417,3 +423,4 @@ export const execute = async (interaction: any) => { | |||
| sendQuestion(interaction); | |||
| }; | |||
|
|
|||
| export { specificQuestionMessage } | |||
There was a problem hiding this comment.
btw use individual exports instead of putting all exports at the end of the file
|
interesting approach. however, we could just keep editing the bot's initial message and then hide the buttons after the last question has been answered this way we could solve this issue and also prevent the dm history from being so cluttered |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.