Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Azure multivalue AT #845

Merged
merged 1 commit into from
Jul 17, 2023
+1 −13
Merged

Fix Azure multivalue AT #845

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions ...java/tech/pegasys/web3signer/tests/bulkloading/AzureKeyVaultMultiValueAcceptanceTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,18 +32,15 @@

import com.azure.core.credential.TokenCredential;
import com.azure.core.exception.ResourceNotFoundException;
import com.azure.core.util.polling.SyncPoller;
import com.azure.identity.ClientSecretCredentialBuilder;
import com.azure.security.keyvault.secrets.SecretClient;
import com.azure.security.keyvault.secrets.SecretClientBuilder;
import com.azure.security.keyvault.secrets.models.DeletedSecret;
import com.azure.security.keyvault.secrets.models.KeyVaultSecret;
import com.azure.security.keyvault.secrets.models.SecretProperties;
import io.restassured.http.ContentType;
import io.restassured.response.Response;
import io.vertx.core.json.JsonObject;
import org.apache.tuweni.bytes.Bytes32;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.condition.EnabledIfEnvironmentVariable;
Expand Down Expand Up @@ -72,7 +69,7 @@ public class AzureKeyVaultMultiValueAcceptanceTest extends AcceptanceTestBase {
private static final String VAULT_NAME = System.getenv("AZURE_KEY_VAULT_NAME");

private static final Map<String, String> TAG_FILTER = Map.of("ENV", "MULTILINE-TEST");
private static final String SECRET_NAME = "TEST-MULTILINE-KEY";
private static final String SECRET_NAME = "ACCTEST-MULTILINE-KEY";

private static List<BLSKeyPair> multiValueKeys;

Expand All @@ -82,15 +79,6 @@ static void setup() {
assertThat(multiValueKeys).hasSize(200);
}

@AfterAll
static void cleanupAzureResources() {
final SecretClient azureSecretClient = buildAzureSecretClient();
final SyncPoller<DeletedSecret, Void> deletedSecretVoidSyncPoller =
azureSecretClient.beginDeleteSecret(SECRET_NAME);
deletedSecretVoidSyncPoller.poll();
deletedSecretVoidSyncPoller.waitForCompletion();
}

@Test
void ensureMultiValueSecretsAreBulkLoadedAndReportedViaPublicKeysApi() {
// filter based on tag
Expand Down