Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

temporary disable Azure and AWS AT #841

Merged
merged 2 commits into from
Jul 13, 2023
Merged

temporary disable Azure and AWS AT #841

merged 2 commits into from
Jul 13, 2023

Conversation

usmansaleem
Copy link
Contributor

PR Description

Temporarily disable Azure and AWS AT

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

  • I thought about testing these changes in a realistic/non-local environment.

siladu
siladu approved these changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@siladu siladu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usmansaleem usmansaleem enabled auto-merge (squash) July 13, 2023 02:48
@gfukushima
Disabling aws
97257d0 
Signed-off-by: Gabriel Fukushima <[email protected]>
@usmansaleem usmansaleem merged commit 2af7f58 into Consensys:master Jul 13, 2023
2 checks passed
usmansaleem added a commit to usmansaleem/web3signer that referenced this pull request Jul 17, 2023
@usmansaleem
Revert "Temporarily disable Azure and AWS AT (Consensys#841)"
4240666 
This reverts commit 2af7f58.
usmansaleem added a commit that referenced this pull request Jul 17, 2023
@usmansaleem
Enable Azure and AWS acceptance test (#843)
e35679f 
* Revert "Temporarily disable Azure and AWS AT (#841)"
This reverts commit 2af7f58.
* Update Azure acceptance test public key
@usmansaleem usmansaleem deleted the disable_azure_aws_AT branch July 20, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siladu siladu siladu approved these changes

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@usmansaleem @siladu @gfukushima