Add eth_sendTransaction #835

gfukushima · 2023-07-06T02:22:36Z

PR Description

Add eth_sendTransaction RPC method under the eth1 subcommand.

Fixed Issue(s)

Fixes #764

Documentation

I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

I thought about adding a changelog entry, and added one if I deemed necessary.

Testing

I thought about testing these changes in a realistic/non-local environment.

Signed-off-by: Gabriel Fukushima <[email protected]>

# Conflicts: # CHANGELOG.md # acceptance-tests/src/test/java/tech/pegasys/web3signer/dsl/signer/SignerConfigurationBuilder.java # core/src/integrationTest/java/tech/pegasys/web3signer/core/jsonrpcproxy/IntegrationTestBase.java # core/src/main/java/tech/pegasys/web3signer/core/Eth1Runner.java # core/src/main/java/tech/pegasys/web3signer/core/service/jsonrpc/EthSendTransactionJsonParameters.java # core/src/main/java/tech/pegasys/web3signer/core/service/jsonrpc/handlers/internalresponse/EthSignTransactionResultProvider.java # core/src/main/java/tech/pegasys/web3signer/core/service/jsonrpc/handlers/sendtransaction/NonceProvider.java # core/src/main/java/tech/pegasys/web3signer/core/service/jsonrpc/handlers/sendtransaction/transaction/EthTransaction.java # core/src/main/java/tech/pegasys/web3signer/core/service/jsonrpc/handlers/sendtransaction/transaction/Transaction.java # core/src/main/java/tech/pegasys/web3signer/core/service/jsonrpc/handlers/signing/ChainIdProvider.java # core/src/main/java/tech/pegasys/web3signer/core/service/jsonrpc/handlers/signing/ConfigurationChainId.java # core/src/main/java/tech/pegasys/web3signer/core/service/jsonrpc/handlers/signing/TransactionSerializer.java # core/src/test/java/tech/pegasys/web3signer/core/service/jsonrpc/EthSignTransactionResultProviderTest.java # core/src/test/java/tech/pegasys/web3signer/core/service/jsonrpc/handlers/transaction/EthTransactionTest.java

Signed-off-by: Gabriel Fukushima <[email protected]>

...ch/pegasys/web3signer/core/service/jsonrpc/sendtransaction/DownstreamPathCalculatorTest.java

Signed-off-by: Gabriel Fukushima <[email protected]>

…to add_eth_sendTransaction

Signed-off-by: Gabriel Fukushima <[email protected]>

.../pegasys/web3signer/core/service/jsonrpc/sendtransaction/transaction/EthTransactionTest.java

…endTransaction Signed-off-by: Gabriel Fukushima <[email protected]>

Co-authored-by: Simon Dudley <[email protected]>

Signed-off-by: Gabriel Fukushima <[email protected]>

jframe · 2023-07-13T01:59:24Z

acceptance-tests/src/test/resources/besu/eth_hash_2018_no_replay_protection.json

+    "chainId": 2018,
+    "homesteadBlock": 0,
+    "daoForkBlock": 0,
+    "eip150Block": 0,


We should a later fork for testing. London is the latest we support for EthHash I think

My PR adds londonBlock to one of these files at least

jframe · 2023-07-13T01:59:58Z

acceptance-tests/src/test/resources/besu/eth_hash_4404.json

+    "eip158Block": 0,
+    "byzantiumBlock": 0,
+    "constantinopleBlock": 0,
+    "constantinopleFixBlock": 0,


Same as above, we should use at a later hard fork

core/src/main/java/tech/pegasys/web3signer/core/Eth1Runner.java

core/src/main/java/tech/pegasys/web3signer/core/service/http/handlers/ReloadHandler.java

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdpater.java

signing/src/main/java/tech/pegasys/web3signer/signing/secp256k1/SingleSignerProvider.java

Signed-off-by: Gabriel Fukushima <[email protected]>

…ecpArtifactSignerProviderAdpater.java Co-authored-by: Jason Frame <[email protected]>

Signed-off-by: Gabriel Fukushima <[email protected]>

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdpater.java

Signed-off-by: Gabriel Fukushima <[email protected]>

...ntegrationTest/java/tech/pegasys/web3signer/keystore/hashicorp/HashicorpIntegrationTest.java

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdapter.java

...ntegrationTest/java/tech/pegasys/web3signer/keystore/hashicorp/HashicorpIntegrationTest.java

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdapter.java

core/src/main/java/tech/pegasys/web3signer/core/service/http/handlers/ReloadHandler.java

Signed-off-by: Gabriel Fukushima <[email protected]>

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdapter.java

jframe · 2023-07-18T05:47:16Z

Can you also add a changelog entry for this

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdapter.java

Signed-off-by: Gabriel Fukushima <[email protected]>

siladu

LGTM

gfukushima added 13 commits June 27, 2023 10:44

add eth_signTransaction

560a21c

Signed-off-by: Gabriel Fukushima <[email protected]>

add bouncycastle to test in the core package

9193fb2

Signed-off-by: Gabriel Fukushima <[email protected]>

Add eth_sendTransaction

a1fcf02

Signed-off-by: Gabriel Fukushima <[email protected]>

Change DefaultTestBase method name to setupWeb3Signer

f795d52

Signed-off-by: Gabriel Fukushima <[email protected]>

Change account used by eth_accounts and IT base

ddcb571

Signed-off-by: Gabriel Fukushima <[email protected]>

Call setupWeb3Signer

439c9fb

Signed-off-by: Gabriel Fukushima <[email protected]>

Extend DefaultTestBase

0e46208

Signed-off-by: Gabriel Fukushima <[email protected]>

Integration tests fixes + spotless

df52f8c

Signed-off-by: Gabriel Fukushima <[email protected]>

Acceptance tests

6e53e0a

Signed-off-by: Gabriel Fukushima <[email protected]>

Remove unused methods

e83d585

Signed-off-by: Gabriel Fukushima <[email protected]>

Some extra fixes

ac65c92

Signed-off-by: Gabriel Fukushima <[email protected]>

spotless

4d07dcd

Signed-off-by: Gabriel Fukushima <[email protected]>

gfukushima added doc-change-required Indicates an issue or PR that requires doc to be updated TeamCerberus Under active development by TeamCerberus @Consensys labels Jul 6, 2023

gfukushima changed the title ~~Add eth send transaction~~ Add eth_sendTransaction Jul 6, 2023

github-advanced-security bot found potential problems Jul 6, 2023

View reviewed changes

...ch/pegasys/web3signer/core/service/jsonrpc/sendtransaction/DownstreamPathCalculatorTest.java Fixed Show fixed Hide fixed

gfukushima added 10 commits July 6, 2023 13:43

Fix proxy integration tests

e4d4643

Signed-off-by: Gabriel Fukushima <[email protected]>

Fix proxy integration tests

cdb5625

Signed-off-by: Gabriel Fukushima <[email protected]>

Fix proxy integration tests

35c2002

Signed-off-by: Gabriel Fukushima <[email protected]>

Fix proxy integration tests

4f6dd05

Signed-off-by: Gabriel Fukushima <[email protected]>

spotless

0ebf80a

Signed-off-by: Gabriel Fukushima <[email protected]>

Merge remote-tracking branch '_gfukushima/add_eth_sendTransaction' in…

42fe2f8

…to add_eth_sendTransaction

spotless

8977e48

Signed-off-by: Gabriel Fukushima <[email protected]>

AT fix

cf81a1c

Signed-off-by: Gabriel Fukushima <[email protected]>

Add eea_sendTransaction

bfe1743

Signed-off-by: Gabriel Fukushima <[email protected]>

spotless

70482fc

Signed-off-by: Gabriel Fukushima <[email protected]>

siladu reviewed Jul 7, 2023

View reviewed changes

.../pegasys/web3signer/core/service/jsonrpc/sendtransaction/transaction/EthTransactionTest.java Outdated Show resolved Hide resolved

siladu mentioned this pull request Jul 7, 2023

Eth1 RPC - Support public 1559 transactions #836

Merged

3 tasks

Add adapter to handle eth1 address identifiers for the eth_sign/eth_s…

405db63

…endTransaction Signed-off-by: Gabriel Fukushima <[email protected]>

gfukushima and others added 5 commits July 12, 2023 15:08

Update core/src/main/java/tech/pegasys/web3signer/core/Runner.java

a1421f4

Co-authored-by: Simon Dudley <[email protected]>

Address PR comments

61eb8df

Signed-off-by: Gabriel Fukushima <[email protected]>

Enable test

bbd8e93

Signed-off-by: Gabriel Fukushima <[email protected]>

Move implementation back to use list

a3c1d6f

Signed-off-by: Gabriel Fukushima <[email protected]>

Merge branch 'master' into add_eth_sendTransaction

8abde11

jframe reviewed Jul 13, 2023

View reviewed changes

gfukushima and others added 5 commits July 13, 2023 17:08

Address comments part 2

be185ee

Signed-off-by: Gabriel Fukushima <[email protected]>

Moving packages and fix reference

8e68e72

Signed-off-by: Gabriel Fukushima <[email protected]>

spotless

c7b8054

Signed-off-by: Gabriel Fukushima <[email protected]>

Update signing/src/main/java/tech/pegasys/web3signer/signing/config/S…

7bd851b

…ecpArtifactSignerProviderAdpater.java Co-authored-by: Jason Frame <[email protected]>

spotless

404039b

Signed-off-by: Gabriel Fukushima <[email protected]>

siladu reviewed Jul 17, 2023

View reviewed changes

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdpater.java Outdated Show resolved Hide resolved

Merge branch 'master' into add_eth_sendTransaction

a8e146c

gfukushima enabled auto-merge (squash) July 18, 2023 00:43

Comments part 3

72c5ff4

Signed-off-by: Gabriel Fukushima <[email protected]>

jframe reviewed Jul 18, 2023

View reviewed changes

gfukushima added 2 commits July 18, 2023 15:06

Comments part 4

1443e35

Signed-off-by: Gabriel Fukushima <[email protected]>

rename params

6052c7e

Signed-off-by: Gabriel Fukushima <[email protected]>

siladu reviewed Jul 18, 2023

View reviewed changes

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdapter.java Outdated Show resolved Hide resolved

jframe reviewed Jul 18, 2023

View reviewed changes

.../src/main/java/tech/pegasys/web3signer/signing/config/SecpArtifactSignerProviderAdapter.java Outdated Show resolved Hide resolved

gfukushima added 4 commits July 18, 2023 15:53

use method reference

c960767

Signed-off-by: Gabriel Fukushima <[email protected]>

Merge branch 'master' into add_eth_sendTransaction

68f4227

rename var

44bb540

Signed-off-by: Gabriel Fukushima <[email protected]>

add changelog

a5aeaf8

Signed-off-by: Gabriel Fukushima <[email protected]>

siladu approved these changes Jul 18, 2023

View reviewed changes

gfukushima merged commit 02e9c55 into Consensys:master Jul 18, 2023
2 checks passed

alexandratran mentioned this pull request Jul 18, 2023

Document eth_sendTransaction Consensys/doc.web3signer#191

Closed

alexandratran removed the doc-change-required Indicates an issue or PR that requires doc to be updated label Jul 18, 2023

gfukushima deleted the add_eth_sendTransaction branch July 27, 2023 23:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add eth_sendTransaction #835

Add eth_sendTransaction #835

gfukushima commented Jul 6, 2023

jframe Jul 13, 2023

siladu Jul 13, 2023

jframe Jul 13, 2023

jframe commented Jul 18, 2023

siladu left a comment

Add eth_sendTransaction #835

Add eth_sendTransaction #835

Conversation

gfukushima commented Jul 6, 2023

PR Description

Fixed Issue(s)

Documentation

Changelog

Testing

jframe Jul 13, 2023

Choose a reason for hiding this comment

siladu Jul 13, 2023

Choose a reason for hiding this comment

jframe Jul 13, 2023

Choose a reason for hiding this comment

jframe commented Jul 18, 2023

siladu left a comment

Choose a reason for hiding this comment