Support aliases in environment variables and YAML configuration #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Dudley <[email protected]>
3 tasks
gfukushima
approved these changes
Jun 28, 2023
| @@ -119,9 +119,9 @@ dependencyManagement { | |||
| entry 'besu' | |||
| entry ('core') { | |||
| exclude group: 'com.github.jnr', name: 'jnr-unixsocket' | |||
| exclude group: 'org.bouncycastle', name: 'bcprov-jdk15on' | |||
There was a problem hiding this comment.
Why is this still needed?
There was a problem hiding this comment.
My guess is that since the artefact name itself changed, it's not possible for gradle to automatically resolve to the jdk18 version. We're using a version of web3j that pulls in the old one. I tried upgrading web3j first and it caused other issues so aborted that, but we should revisit.
I believe the utils module is a dependency of core. In an earlier commit I had introduced the utils entry simply to be able to exclude bouncycastle. In this PR I realised I could simplify that by moving the exclude.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Supporting PR for #826
Before this PR, the only aliases that were supported were the ones with the longest name. This makes sense when your aliases are always short name versions of the options, e.g.
--logging, -l.It doesn't make sense when you want to use aliases as a way to rename an option as for #586
This PR allows 'short name options' with a single leading dash to be converted into environment variables and YAML config items.
I have opened another issue to discuss whether we should handle these differently to the long name options: #824
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Testing