Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with Java 21 and gradle 8.8 #18

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

lu-pinto
Copy link

@lu-pinto lu-pinto commented Dec 16, 2024

PR description

This PR makes building possible with Java 21 and Gradle 8.8. Chose the same version of Gradle as besu just for consistency, but I think we could upgrade it even further.
I did not test releasing. If there are any changes for that, that will be in another PR - this one just focus on getting a green build.

Fixed Issue(s)

fixes #12
fixes #13

@lu-pinto lu-pinto force-pushed the fix-build branch 2 times, most recently from 2e8de75 to 66b4897 Compare December 16, 2024 10:14
Signed-off-by: Luis Pinto <[email protected]>
Signed-off-by: Luis Pinto <[email protected]>
@lu-pinto lu-pinto marked this pull request as ready for review December 19, 2024 11:57
@lu-pinto
Copy link
Author

gradle build pTML is now working so I was able to test building besu with this version and it works. Besu reference tests are also green with new version.

Copy link
Collaborator

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla merged commit 5383996 into Consensys:main Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to Gradle 8 upgrade to Java 21
2 participants