Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pending attestations to trigger recent block fetcher #8907

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Dec 10, 2024

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@lucassaldanha lucassaldanha added the DO NOT MERGE Not ready to merge label Dec 10, 2024
@lucassaldanha
Copy link
Member

This is interesting. Totally something I expected Teku was already doing, but it looks like it hasn't done it in a long time... Was it deliberate??

The changes make sense. My only concern is if we could end up fetching blocks too aggressively. Either way, we are better doing some throughout sync testing to see.

@tbenr
Copy link
Contributor Author

tbenr commented Dec 18, 2024

@lucassaldanha
I did some syncing test and all seems fine. since we don't do any RPC if we are not in sync, then all the attempts when we are syncing close to the head are skipped anyway. I think we can go for it.

@tbenr tbenr enabled auto-merge (squash) December 19, 2024 08:18
@tbenr tbenr removed the DO NOT MERGE Not ready to merge label Dec 19, 2024
@tbenr tbenr merged commit 7551460 into Consensys:master Dec 19, 2024
14 of 16 checks passed
@tbenr tbenr deleted the let-pending-attestation-trigger-recent-block-fetcher branch December 19, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants