Reduce blobs lookup min wait time to 0 #8864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
approved these changes
Nov 29, 2024
rolfyone
reviewed
Nov 29, 2024
| @@ -93,7 +93,7 @@ public class BlockBlobSidecarsTrackersPoolImpl extends AbstractIgnoringFutureHis | |||
| static final String GAUGE_BLOB_SIDECARS_TRACKERS_LABEL = "blob_sidecars_trackers"; | |||
|
|
|||
| static final UInt64 MAX_WAIT_RELATIVE_TO_ATT_DUE_MILLIS = UInt64.valueOf(1500); | |||
| static final UInt64 MIN_WAIT_MILLIS = UInt64.valueOf(500); | |||
| static final UInt64 MIN_WAIT_MILLIS = UInt64.valueOf(0); | |||
There was a problem hiding this comment.
i'd probably use UINT64.ZERO
There was a problem hiding this comment.
haha I can but bad code even on a constant value change 🥲
tbenr
added a commit
to tbenr/teku
that referenced
this pull request
Dec 11, 2024
This reverts commit 809ea98.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have decent getBlobs support, we can lookup blobs faster when the block shows up close to 4s boundary
related to #8796
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog