Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove delay when looking up blobs via local EL #8796

Open
tbenr opened this issue Oct 29, 2024 · 1 comment · May be fixed by #8927
Open

Remove delay when looking up blobs via local EL #8796

tbenr opened this issue Oct 29, 2024 · 1 comment · May be fixed by #8927
Assignees
@StefanBratanov

Comments

@tbenr
Copy link
Contributor

tbenr commented Oct 29, 2024

Once there is enough adoption of engine_getBlobs we can remove the delay and do the local lookup of the missing blobs immediately once we receive the block.
RPC delay should remain unchanged.
@Consensys Consensys deleted a comment from samr874 Oct 29, 2024
@tbenr tbenr mentioned this issue Nov 29, 2024
Merged
2 tasks
@tbenr tbenr mentioned this issue Dec 11, 2024
Merged
2 tasks
@tbenr
Copy link
Contributor Author

tbenr commented Dec 11, 2024 •
edited
Loading

some informations:

  1. we should not try to lookup the block via RPC too fast when we first see a blob sidecar. The process when we receive a blob first could be
  • store it
  • wait (maybe with the same "elastic" logic but with different params)
  • fetch block RPC if not received yet.
  1. I think we can remove the attempt to recover blobs when we still don't have a block. Currently we try to download all max blobs (6). In Electra it will be even 9. I think we could be less aggressive now that we have local EL option.
  2. the process when we receive a block could be
  • immediately lookup for blobs via local EL
  • (not sure we should add a delay here, currently we don't)
  • broadcast reconstructed blobs
  • (delay here?)
  • lookup still missing blobs via RPC

@StefanBratanov StefanBratanov self-assigned this Dec 13, 2024
@StefanBratanov StefanBratanov linked a pull request Dec 16, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StefanBratanov StefanBratanov

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@StefanBratanov @tbenr