-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(oogx): CALL different scenarios #1515
Draft
lorenzogentile404
wants to merge
8
commits into
arith-dev
Choose a base branch
from
1514-call-exceptions-testing
base: arith-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenzogentile404
changed the title
test(oogx): add draft for CALL
test(oogx): CALL different scenarios
Nov 19, 2024
WRT Line 162 in 41a0c0b
The method can definitely be simplified (e.g. there is no need for nested if .. else .. .) Also it is missing memory expansion costs. Maybe we could use the static Hub.GAS_PROJECTOR 's methods ?
|
lorenzogentile404
force-pushed
the
1514-call-exceptions-testing
branch
from
December 18, 2024 17:45
1e0286c
to
503455c
Compare
@OlivierBBB using
that also requires the frame. Let's have a chat about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.