fix: add validations to block number params of trace generation and l…

…ine counting JSON-RPC endpoints (#1191)


Signed-off-by: Tsvetan Dimitrov <[email protected]>

arithmetization/src/main/java/net/consensys/linea/plugins/rpc/counters/CountersRequestParams.java

@@ -21,13 +21,19 @@
 
 /** Holds needed parameters for sending an execution trace generation request. */
 public record CountersRequestParams(long blockNumber, String expectedTracesEngineVersion) {
-  public void validateTracerVersion() {
+  public void validate() {
     if (!expectedTracesEngineVersion.equals(getTracerRuntime())) {
       throw new InvalidParameterException(
           String.format(
               "INVALID_TRACES_VERSION: Runtime version is %s, requesting version %s",
               getTracerRuntime(), expectedTracesEngineVersion));
     }
+
+    if (blockNumber < 0) {
+      throw new InvalidParameterException(
+          "INVALID_BLOCK_NUMBER: blockNumber: %d cannot be a negative number"
+              .formatted(blockNumber));
+    }
   }
 
   private static String getTracerRuntime() {

arithmetization/src/main/java/net/consensys/linea/plugins/rpc/counters/GenerateCountersV2.java

@@ -81,7 +81,7 @@ public Counters execute(final PluginRpcRequest request) {
       final CountersRequestParams params =
           CONVERTER.fromJson(CONVERTER.toJson(rawParams[0]), CountersRequestParams.class);
 
-      params.validateTracerVersion();
+      params.validate();
 
       final long requestedBlockNumber = params.blockNumber();
 

arithmetization/src/main/java/net/consensys/linea/plugins/rpc/tracegeneration/GenerateConflatedTracesV2.java

@@ -83,7 +83,7 @@ public TraceFile execute(final PluginRpcRequest request) {
       TraceRequestParams params =
           CONVERTER.fromJson(CONVERTER.toJson(rawParams[0]), TraceRequestParams.class);
 
-      params.validateTracerVersion();
+      params.validate();
 
       final long fromBlock = params.startBlockNumber();
       final long toBlock = params.endBlockNumber();

arithmetization/src/main/java/net/consensys/linea/plugins/rpc/tracegeneration/TraceRequestParams.java

@@ -23,12 +23,29 @@
 public record TraceRequestParams(
     long startBlockNumber, long endBlockNumber, String expectedTracesEngineVersion) {
 
-  public void validateTracerVersion() {
+  public void validate() {
     if (!expectedTracesEngineVersion.equals(getTracerRuntime())) {
       throw new InvalidParameterException(
-          String.format(
-              "INVALID_TRACES_VERSION: Runtime version is %s, requesting version %s",
-              getTracerRuntime(), expectedTracesEngineVersion));
+          "INVALID_TRACES_VERSION: Runtime version is %s, requesting version %s"
+              .formatted(getTracerRuntime(), expectedTracesEngineVersion));
+    }
+
+    if (startBlockNumber < 0) {
+      throw new InvalidParameterException(
+          "INVALID_START_BLOCK_NUMBER: startBlockNumber: %d cannot be a negative number"
+              .formatted(startBlockNumber));
+    }
+
+    if (endBlockNumber < 0) {
+      throw new InvalidParameterException(
+          "INVALID_END_BLOCK_NUMBER: endBlockNumber: %d cannot be a negative number"
+              .formatted(endBlockNumber));
+    }
+
+    if (endBlockNumber - startBlockNumber < 0) {
+      throw new InvalidParameterException(
+          "INVALID_END_BLOCK_NUMBER: endBlockNumber: %d cannot be less than startBlockNumber: %d"
+              .formatted(endBlockNumber, startBlockNumber));
     }
   }