-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Module Line Count Verification to linea_estimateGas
RPC Method
#1
Merged
Gabriel-Trintinalia
merged 11 commits into
main
from
feat/issue-918/estimate-gas-limit-module
Apr 10, 2024
Merged
Extend Module Line Count Verification to linea_estimateGas
RPC Method
#1
Gabriel-Trintinalia
merged 11 commits into
main
from
feat/issue-918/estimate-gas-limit-module
Apr 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gabriel-Trintinalia
changed the title
Feat/issue 918/estimate gas limit module
Extend Module Line Count Verification to Apr 9, 2024
linea_estimateGas
RPC Method
fab-10
reviewed
Apr 9, 2024
arithmetization/src/main/java/net/consensys/linea/config/LineaTracerConfiguration.java
Outdated
Show resolved
Hide resolved
...hmetization/src/main/java/net/consensys/linea/config/LineaTracerConfigurationCLiOptions.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/rpc/linea/LineaEstimateGas.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/rpc/linea/LineaEstimateGas.java
Show resolved
Hide resolved
...on/src/main/java/net/consensys/linea/sequencer/modulelimit/ModuleLimitsValidationResult.java
Outdated
Show resolved
Hide resolved
...on/src/main/java/net/consensys/linea/sequencer/modulelimit/ModuleLimitsValidationResult.java
Outdated
Show resolved
Hide resolved
...a/net/consensys/linea/sequencer/txselection/selectors/TraceLineLimitTransactionSelector.java
Outdated
Show resolved
Hide resolved
...a/net/consensys/linea/sequencer/txselection/selectors/TraceLineLimitTransactionSelector.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/zktracer/module/rlp/txn/RlpTxnChunk.java
Show resolved
Hide resolved
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Gabriel-Trintinalia
force-pushed
the
feat/issue-918/estimate-gas-limit-module
branch
from
April 9, 2024 13:28
45fa4eb
to
83396d4
Compare
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
fab-10
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple of minor things
...on/src/main/java/net/consensys/linea/sequencer/modulelimit/ModuleLimitsValidationResult.java
Outdated
Show resolved
Hide resolved
arithmetization/src/main/java/net/consensys/linea/rpc/linea/LineaEstimateGas.java
Show resolved
Hide resolved
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Signed-off-by: Gabriel-Trintinalia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main Changes:
ModuleLineCountValidator
. This change allows for the reuse of module validation logic across different parts of the pluginmoduleLimitFilePath
configuration has been moved out of the transaction selection configuration and into its own dedicated tracer configuration.linea_estimateGas
RPC method has been changed to include module limit validation.TracerAggregator
class has been implemented to delegate tracing methods to multiple tracers.Pending: