Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coordinator: update besu dependency #475

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 20, 2024 13:39 — with GitHub Actions Inactive
@jpnovais jpnovais requested a review from a team December 20, 2024 14:25
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 12 lines in your changes missing coverage. Please review.

Project coverage is 68.16%. Comparing base (4a7b76c) to head (08e106f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...lin/net/consensys/zkevm/ethereum/AccountManager.kt 63.63% 8 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #475      +/-   ##
============================================
- Coverage     68.22%   68.16%   -0.06%     
  Complexity     1128     1128              
============================================
  Files           319      319              
  Lines         12795    12815      +20     
  Branches       1277     1280       +3     
============================================
+ Hits           8729     8735       +6     
- Misses         3540     3549       +9     
- Partials        526      531       +5     
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø) Carriedforward from dd74d77
kotlin 65.78% <63.63%> (-0.07%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...lin/net/consensys/zkevm/ethereum/AccountManager.kt 73.84% <63.63%> (-3.43%) ⬇️

... and 2 files with indirect coverage changes

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e December 20, 2024 15:38 — with GitHub Actions Inactive
@jpnovais jpnovais requested a deployment to docker-build-and-e2e December 20, 2024 16:12 — with GitHub Actions Waiting
@Anon-im
Copy link

Anon-im commented Dec 22, 2024

Thats cool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants