Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct errors in description lines of the code #378

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Anon-im
Copy link

@Anon-im Anon-im commented Dec 3, 2024

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@Anon-im Anon-im requested a review from a team as a code owner December 3, 2024 05:52
@Anon-im Anon-im changed the title fix: Correct errors in code and docs fix: Correct errors in description lines of the code Dec 3, 2024
@Anon-im Anon-im force-pushed the Correct branch 2 times, most recently from a1564c3 to ccb1849 Compare December 4, 2024 09:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.17%. Comparing base (741afee) to head (1b9292a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #378   +/-   ##
=========================================
  Coverage     70.17%   70.17%           
  Complexity     1070     1070           
=========================================
  Files           306      306           
  Lines         12337    12337           
  Branches       1179     1179           
=========================================
  Hits           8658     8658           
  Misses         3200     3200           
  Partials        479      479           
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 67.86% <ø> (ø) Carriedforward from 6379d3f

*This pull request uses carry forward flags. Click here to find out more.

@Anon-im
Copy link
Author

Anon-im commented Dec 5, 2024

@thedarkjester Made all requested changes!

@Anon-im
Copy link
Author

Anon-im commented Dec 6, 2024

Made all changes as required @thedarkjester

@Anon-im
Copy link
Author

Anon-im commented Dec 22, 2024

@thedarkjester hello! I'va made all changes as required! Ready for review and merge!

Copy link
Author

@Anon-im Anon-im left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finished @thedarkjester

contracts/contracts/test-contracts/LineaRollupV5.sol Outdated Show resolved Hide resolved
contracts/scripts/hardhat/postCompile.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants