Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump actions-checkout to v4 and fix config test error #246

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

jonesho
Copy link
Contributor

@jonesho jonesho commented Oct 25, 2024

This PR implements issue(s) #181

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jonesho jonesho requested a review from Filter94 October 25, 2024 11:30
@jonesho jonesho self-assigned this Oct 25, 2024
@jonesho jonesho had a problem deploying to docker-build-and-e2e October 25, 2024 11:31 — with GitHub Actions Error
@jonesho jonesho requested a review from VGau October 25, 2024 11:35
VGau
VGau previously approved these changes Oct 25, 2024
@jonesho jonesho force-pushed the feat/bump-actions-checkout-to-v4-and-fix-config-test branch from 5e0a249 to d040714 Compare October 25, 2024 14:28
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 25, 2024 14:29 — with GitHub Actions Inactive
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.61%. Comparing base (99583ae) to head (d040714).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #246   +/-   ##
=========================================
  Coverage     71.61%   71.61%           
  Complexity     1084     1084           
=========================================
  Files           299      299           
  Lines         12145    12145           
  Branches       1083     1083           
=========================================
  Hits           8698     8698           
  Misses         2956     2956           
  Partials        491      491           
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from 99583ae
kotlin 69.43% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@jonesho jonesho enabled auto-merge (squash) October 25, 2024 14:57
@jonesho jonesho requested a review from VGau October 25, 2024 14:59
@jonesho jonesho disabled auto-merge October 25, 2024 16:06
@jonesho jonesho merged commit 8d679ef into main Oct 25, 2024
29 checks passed
@jonesho jonesho deleted the feat/bump-actions-checkout-to-v4-and-fix-config-test branch October 25, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants