Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

526 blockdata redesign #543

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

526 blockdata redesign #543

wants to merge 30 commits into from

Conversation

lorenzogentile404
Copy link
Contributor

No description provided.

lorenzogentile404 and others added 18 commits December 4, 2024 17:14
@lorenzogentile404
feat(blockdata): partially update columns
92d6a37
@lorenzogentile404
feat(blockhash): complete update columns
8317097
@lorenzogentile404
feat(blockdata): partially add module call macros
ac43e4c
@amkCha
feat(blockdata): finish call macro modules
8383612
@amkCha
feat(blockdata): partial shorthands
e8dce98
@amkCha
feat(blockdata): shorthands but curr_prev
115b35e
@amkCha
feat(blockdata): finish shorthands
50c6cca
@lorenzogentile404
feat(blockdata): revise shorthands
5cb6f96
@amkCha
feat(blockdata): unconditional constraints
3fd3913
@amkCha
feat(blockdata): completed constancies
ae0ea81
@amkCha
feat(blockdata): start heartbeat
89b1e8f
@amkCha
feat(blockdata): completed heartbeat
e84ad80
@amkCha
fix(blockdata): heartbeat
1ae49b1
@lorenzogentile404
feat(blockdata): partially implement computations and checks and lookups
3f5041f
@amkCha
feat(blockdata): comparison and checks number
c76ba6a
@amkCha
feat(blockdata): computations and checks for difficulty
53b3365
@amkCha
feat(blockdata): computations and checks finish + euc lookup
2c7083c
@amkCha
feat(blockdata): checks and lookups review
7dfb183
@lorenzogentile404 lorenzogentile404 linked an issue Dec 9, 2024 that may be closed by this pull request
BLOCKDATA redesign #526
Open
OlivierBBB
OlivierBBB reviewed Dec 9, 2024
View reviewed changes
blockdata/constants.lisp Outdated Show resolved Hide resolved
@OlivierBBB
Copy link
Collaborator

OlivierBBB commented Dec 10, 2024 •
edited
Loading

The conversations are marked as resolved but most of them haven't been addressed. Is this PR missing the latest commit ? Edit I seem to have been looking at a deprecated version.

OlivierBBB
OlivierBBB reviewed Dec 10, 2024
View reviewed changes
blockdata/constants.lisp
CT_MAX_GL 5
CT_MAX_ID 1
CT_MAX_BF 1
CT_MAX_DEPTH (+ CT_MAX_CB CT_MAX_TS CT_MAX_NB CT_MAX_DF CT_MAX_GL CT_MAX_ID CT_MAX_BF)
Copy link
Collaborator

@OlivierBBB OlivierBBB Dec 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this compile ? If so that's pretty interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierBBB OlivierBBB OlivierBBB left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BLOCKDATA redesign
3 participants
@lorenzogentile404 @OlivierBBB @amkCha