-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explorer): As a User, I want to see a disclaimer on the expiration date #853
Conversation
…d list item props to include tooltip
Hey @Chirag-S-Kotian, Great work on the tooltip addition! A quick suggestion regarding the description of this PR (and some previous ones): the level of detail feels a bit excessive for such a straightforward change. A more concise explanation might make it easier for reviewers to focus on the key points. Also, it would be awesome if you could follow the PR template defined here. You can still use the space between "What does this PR do?" and "Related ticket" to provide any additional context or details about your work. Lastly, just a friendly reminder to name the PR according to the pattern in the Contribution Doc. Thanks for your effort—it’s much appreciated! 👍 |
explorer/src/pages/Attestation/components/AttestationInfo/index.tsx
Outdated
Show resolved
Hide resolved
…map, and moved tooltip to specific list item
@Chirag-S-Kotian 2 general comments on the UI rendeered:
|
Hey @Chirag-S-Kotian |
hy @alainncls i fixed it now ,see this ,is it okay? |
What does this PR do?
Description
Added a tooltip to provide clarity about attestation expiration dates. This enhancement helps users better understand that attestation validity is determined by the issuer and that adherence to expiration dates is optional for consumers.
Changes
Implementation Details
Testing
Related ticket
Fixes #570
Type of change
Check list