Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): As a User, I want to see a disclaimer on the expiration date #853

Merged
merged 6 commits into from
Dec 16, 2024

Conversation

Chirag-S-Kotian
Copy link
Contributor

@Chirag-S-Kotian Chirag-S-Kotian commented Dec 3, 2024

What does this PR do?

Description

Added a tooltip to provide clarity about attestation expiration dates. This enhancement helps users better understand that attestation validity is determined by the issuer and that adherence to expiration dates is optional for consumers.

Changes

  • Added an information icon (ℹ️) next to the Expiration Date field in attestation details
  • Implemented hover tooltip using the existing Tooltip component
  • Added disclaimer text explaining the nature of attestation validity
  • Maintained consistent styling with the application's design system

Implementation Details

  • Used Lucide React's Info icon for the tooltip trigger
  • Leveraged the existing Tooltip component for consistency
  • Added tooltip content through the list item configuration
  • Ensured proper spacing and alignment with existing UI elements

Testing

  • Verified tooltip appears on hover
  • Confirmed tooltip text is correct and readable
  • Tested in both light and dark modes
  • Ensured responsive behavior across different screen sizes

Related ticket

Fixes #570

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls
Copy link
Collaborator

Hey @Chirag-S-Kotian,

Great work on the tooltip addition! A quick suggestion regarding the description of this PR (and some previous ones): the level of detail feels a bit excessive for such a straightforward change. A more concise explanation might make it easier for reviewers to focus on the key points.

Also, it would be awesome if you could follow the PR template defined here. You can still use the space between "What does this PR do?" and "Related ticket" to provide any additional context or details about your work.

Lastly, just a friendly reminder to name the PR according to the pattern in the Contribution Doc.

Thanks for your effort—it’s much appreciated! 👍

…map, and moved tooltip to specific list item
@alainncls
Copy link
Collaborator

alainncls commented Dec 6, 2024

@Chirag-S-Kotian 2 general comments on the UI rendeered:

  1. Let's try to re-align the 2 columns, as the icon pushes the date to the right:
image
  1. The tooltip seems to be to narrow, the text is not readable:
image

@alainncls alainncls changed the title As a User, I want to see a disclaimer on the expiration date feat(explorer): As a User, I want to see a disclaimer on the expiration date Dec 6, 2024
@alainncls
Copy link
Collaborator

Hey @Chirag-S-Kotian
The right column still doesn't seem to be aligned because of the new icon:
image
YOu should probably give a bit more width to the left column 😉

@Chirag-S-Kotian
Copy link
Contributor Author

hy @alainncls i fixed it now ,see this ,is it okay?

image

@alainncls alainncls merged commit 7827f8d into Consensys:dev Dec 16, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a User, I want to see a disclaimer on the expiration date
2 participants