Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(explorer): As a user, I want the Subject Page title to be explicit #816

Merged

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

Adds a title to the Subject Page
Adds a copyable address as subtitle

Related ticket

Fixes #815

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request November 25, 2024 16:38 Inactive
@alainncls alainncls merged commit c56c71b into dev Nov 25, 2024
11 checks passed
@alainncls alainncls deleted the feat/as-a-user-i-want-the-subject-page-title-to-be-explicit branch November 25, 2024 16:40
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.96%. Comparing base (3087119) to head (14c40a5).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #816   +/-   ##
=======================================
  Coverage   48.96%   48.96%           
=======================================
  Files          18       18           
  Lines         388      388           
  Branches       61       61           
=======================================
  Hits          190      190           
  Misses        195      195           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As a user, I want the Subject Page title to be explicit
4 participants