feat(explorer): As a user, I want to see Expired and Revoked Attestations with a watermark on the Subject page #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyajeetkolhapure
requested review from
alainncls,
orbmis and
arthur-remy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #794 +/- ##
=======================================
Coverage 47.60% 47.60%
=======================================
Files 18 18
Lines 397 397
Branches 60 60
=======================================
Hits 189 189
Misses 205 205
Partials 3 3 ☔ View full report in Codecov by Sentry. |
alainncls
requested changes
Nov 7, 2024
alainncls
reviewed
Nov 8, 2024
explorer/src/pages/Attestation/components/AttestationCard/index.tsx
Outdated
Show resolved
Hide resolved
alainncls
approved these changes
Nov 8, 2024
alainncls
force-pushed
the
feat/as-a-user-i-want-to-see-expired-and-revoked-attestations-with-a-watermark-on-the-subject-page
branch
from
cf382da to
28bec4f
Compare
alainncls
force-pushed
the
feat/as-a-user-i-want-to-see-expired-and-revoked-attestations-with-a-watermark-on-the-subject-page
branch
from
28bec4f to
8d31450
Compare
alainncls
deleted the
feat/as-a-user-i-want-to-see-expired-and-revoked-attestations-with-a-watermark-on-the-subject-page
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
For revoked attestations a watermark with red colour and revoked text is added.
For expired attestations card is greyed out
Related ticket
Fixes #755
Type of change
Check list