feat(explorer): As a user, I want to see unknown Attestations with a default display #793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satyajeetkolhapure
requested review from
alainncls,
orbmis and
arthur-remy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #793 +/- ##
=======================================
Coverage 46.64% 46.64%
=======================================
Files 18 18
Lines 388 388
Branches 57 57
=======================================
Hits 181 181
Misses 205 205
Partials 2 2 ☔ View full report in Codecov by Sentry. |
alainncls
approved these changes
Nov 7, 2024
alainncls
requested changes
Nov 7, 2024
explorer/src/pages/Attestation/components/AttestationCard/index.tsx
Outdated
Show resolved
Hide resolved
…x.tsx Co-authored-by: Alain Nicolas <[email protected]>
alainncls
approved these changes
Nov 7, 2024
alainncls
deleted the
feat/as-a-user-i--want-to-see-unknown-attestations-with-a-default-display
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Added a default display for attestation card when issuer data is not available for given schema and portal
Related ticket
Fixes #786
Type of change
Check list