feat: Introduce Modules V2 with more flexibility #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #562 +/- ##
==========================================
+ Coverage 93.63% 93.98% +0.34%
==========================================
Files 20 30 +10
Lines 330 432 +102
Branches 76 98 +22
==========================================
+ Hits 309 406 +97
- Misses 10 15 +5
Partials 11 11 ☔ View full report in Codecov by Sentry. |
leifdejong
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Awesome work @alainncls! This would unblock a lot of the use cases we have been exploring. Thank you for your efforts. I would like to suggest you also update the ECDSAModule.sol replacing msg.sender with portal. That's a really useful one.
orbmis
approved these changes
Mar 14, 2024
alainncls
force-pushed
the
feat/modules-v2
branch
5 times, most recently
from
78d100f to
723a9f3
Compare
alainncls
force-pushed
the
dev
branch
4 times, most recently
from
581c2b6 to
f607329
Compare
alainncls
force-pushed
the
feat/modules-v2
branch
from
723a9f3 to
e9fd811
Compare
✅ Deploy Preview for verax-tutorial ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alainncls
force-pushed
the
feat/modules-v2
branch
from
e9fd811 to
86f4ab8
Compare
alainncls
force-pushed
the
feat/modules-v2
branch
from
86f4ab8 to
e0e1888
Compare
alainncls
force-pushed
the
feat/modules-v2
branch
from
e0e1888 to
d8eea55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Introduces a "Modules V2" feature, for more flexibility and more use cases
IssuersPortalV1 = 694065IssuersPortalV2 = 694780=> Increased by 0.1% (715 gas)
Related ticket
Fixes #574
Type of change
Check list