chore: Optimize the revocation of attestations (#148)

Consensys · Sep 4, 2023 · 892eabf · 892eabf
1 parent 88aad2d
commit 892eabf
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/AttestationRegistry.sol b/src/AttestationRegistry.sol
@@ -47,8 +47,6 @@ contract AttestationRegistry is OwnableUpgradeable {
   event AttestationRegistered(bytes32 indexed attestationId);
   /// @notice Event emitted when an attestation is revoked
   event AttestationRevoked(bytes32 attestationId, bytes32 replacedBy);
-  /// @notice Event emitted when a list of attestations is revoked
-  event BulkAttestationsRevoked(bytes32[] attestationId, bytes32[] replacedBy);
   /// @notice Event emitted when the version number is incremented
   event VersionUpdated(uint16 version);
 
@@ -157,8 +155,6 @@ contract AttestationRegistry is OwnableUpgradeable {
     for (uint256 i = 0; i < attestationIds.length; i++) {
       revoke(attestationIds[i], replacedBy[i]);
     }
-
-    emit BulkAttestationsRevoked(attestationIds, replacedBy);
   }
 
   /**

diff --git a/test/AttestationRegistry.t.sol b/test/AttestationRegistry.t.sol
@@ -344,7 +344,10 @@ contract AttestationRegistryTest is Test {
     replacingAttestations[1] = attestationId3;
 
     vm.expectEmit(true, true, true, true);
-    emit BulkAttestationsRevoked(attestationsToRevoke, replacingAttestations);
+    emit AttestationRevoked(attestationsToRevoke[0], replacingAttestations[0]);
+    vm.expectEmit(true, true, true, true);
+    emit AttestationRevoked(attestationsToRevoke[1], replacingAttestations[1]);
+
     attestationRegistry.bulkRevoke(attestationsToRevoke, replacingAttestations);
     vm.stopPrank();