Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update schemes and curves section #29

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yelhousni
Copy link
Contributor

Pull request checklist

Use the following template to make sure your PR fits the ConsenSys documentation standard.

Before creating the PR

Make sure that:

Describe the change

  • added PlonK with FRI polynomial commitment to supported schemes.
  • added BLS24-317 to supported curves.
  • added description of BLS24-317.
  • added reference papers to all curves.

Issue fixed

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@yelhousni yelhousni added the documentation Improvements or additions to documentation label Jun 1, 2023
@yelhousni yelhousni requested review from gbotrel and Ezzahhh June 1, 2023 11:17
@vercel
Copy link

vercel bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
doc-gnark ✅ Ready (Inspect) Visit Preview Jun 1, 2023 11:18am

@yelhousni yelhousni temporarily deployed to no-secret June 1, 2023 11:18 — with GitHub Actions Inactive
@yelhousni yelhousni temporarily deployed to no-secret June 1, 2023 11:18 — with GitHub Actions Inactive
@yelhousni yelhousni temporarily deployed to no-secret June 1, 2023 11:18 — with GitHub Actions Inactive
@yelhousni yelhousni temporarily deployed to no-secret June 1, 2023 11:18 — with GitHub Actions Inactive

Currently, `gnark` supports PlonK with KZG polynomial commitment.
Currently, `gnark` supports PlonK with KZG and FRI polynomial commitments.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the doc should distinguish the level of maturity of KZG and FRI impl here. i.e FRI is very experimental, KZG is less so :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants