Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What you did well:
What you can improve:
four of your
string.js
functions -sayHello
,uppercase
,lowercase
andfirstCharacters
- only work for the strings used as examples in the tests! I love the ingenuity of reverse engineering the tests this way, but it's not how these problems should be solved. You should write functions that work correctly with any string input, not just the 3 examples used in the tests. If you're stuck and don't know how to write these functions, please ask in the Slack channel or in class. There are a number of in-built string methods in JavaScript and it's important to learn these.there's quite a lot of unnecessary if/else statements in your
booleans.js
file. If/else work by evaluating the truthiness/falsiness of the expressions after if/else - but you can skip the if/else and just return the Boolean value the expression evaluates to instead. The ! (NOT) JavaScript operator is very helpful here.For example, you negate function is:
You can re-write this as:
Or even
const negate = a => a === false;
(You don't need to use
return
for single line arrow functions.)Have a go at refactoring all your Boolean functions in this way.
arrays.js
- you usearray2
(an undefined variable) instead ofarray
(variable declared as function parameter):