fix: selecting all pages with advanced/detail search corrected #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for example with the engine set to ^18.19.1 in package.json: avoid selecting 20.18. instead of latest 18.xx * also relax asdf manage nodejs version
headri
commented
Oct 15, 2024
|
|
||
| if (range == 'all') { | ||
| if (this.state.currentSearchSelection && elements[type + "s"].ids) { |
There was a problem hiding this comment.
Just to be sure, the only behavioral change in this file's diff is the removal of this.state.currentSearchSelection from the guard clause? For the future please change behavior and formatting in separate commits.
LCOV of commit
|
JanCBrammer
requested changes
Oct 16, 2024
|
|
||
| if (range == 'all') { | ||
| if (this.state.currentSearchSelection && elements[type + "s"].ids) { |
There was a problem hiding this comment.
Just to be sure, the only behavioral change in this file's diff is the removal of this.state.currentSearchSelection from the guard clause? For the future please change behavior and formatting in separate commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this.state.currentSearchSelection is not set in detail / advanced search
therefore condition removed; the other condition is sufficient
closes https://github.com/ComPlat/chemotion/issues/217