Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add more descriptive text for aria-label #431

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ErriGarcia
Copy link

@ErriGarcia ErriGarcia commented Jun 21, 2023

The attribute aria-label="Scroll to top" suggests that it represents a button or element that allows users to scroll back to the top of a page.

Lack of descriptive text: The aria-label attribute should provide a concise and meaningful description of the button's purpose. However the value "Scroll to top" is not informative enough. Screen readers, which are assistive technologies used by individuals with visual impairments, rely on these labels to convey information to the user.

Solution:
Provide a more descriptive label, such as "Scroll to top of the page," would be more helpful.

Please review the changes and let us know if any further modifications or adjustments are required. I believe these updates will significantly improve the accessibility of the button for users with visual impairments.

Thank you for your attention to this matter.

@ttkapostol @ErriGarcia @NataliaBlanco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant