Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature - Tambahkan fitur download screenshot di halaman preview screenshot #34

Conversation

CoderJava
Copy link
Owner

Untuk saat ini, fitur download foto hanya dipakai untuk dowload foto screenshot saja. Baik foto screenshot yang belum sync maupun yang sudah sync. Dan fitur download foto ini hanya bisa mendownload foto-foto user yang sedang login dan user yang role-nya super admin.

Buat.fitur.download.screenshot.di.halaman.preview.photo.mov

Widget tersebut berfungsi untuk menampilkan loading center full screen overlay
…abase lokal

Perbaikan task name yang kosong ketika dimasukkan kedalam database lokal pada saat stop timer. Ini disebabkan karena function `doTakeScreenshot` bersifat `async` dan setelah pemanggilan function `doTakeScreenshot` ada kode untuk set `selectedTask` menjadi null dan ini menyebabkan ketika diinsert ke database lokal `selectedTask`-nya menjadi null. Jadi, solusinya adalah simpan variable `selectedTask` kedalam variable `selectedTaskTemp`.
Fitur download ini dibuat dalam 2 pengkondisian yaitu, jika file photo-nya ada di server dan ada di lokal. Untuk file photo yang ada di server ini untuk fitur download photo yang sudah naik fotonya ke server. Sementara, untuk file photo yang di lokal ini berarti, file photo-nya masih di lokal.
…didownload atau tidak

Untuk saat ini, download foto hanya dipakai di halaman sync_page.dart dan report_screenshot_page.dart saja. Dan download foto ini hanya berlaku untuk foto user tersebut dan super admin.
@CoderJava CoderJava added bug Something isn't working enhancement New feature or request labels Nov 26, 2023
@CoderJava CoderJava self-assigned this Nov 26, 2023
Copy link

codecov bot commented Nov 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e7af2bf) 100.00% compared to head (6e8e223) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          116       116           
  Lines         1892      1892           
=========================================
  Hits          1892      1892           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CoderJava CoderJava merged commit 60ec6c6 into main Nov 26, 2023
5 checks passed
@CoderJava CoderJava deleted the feature/tambahan-fitur-download-screenshot-di-halaman-preview-screenshot branch November 26, 2023 12:52
@CoderJava CoderJava added the released Has been released label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request released Has been released
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

1 participant