Skip to content

Commit

Permalink
ci: remove 14.x from ci
Browse files Browse the repository at this point in the history
  • Loading branch information
@brettstack
brettstack committed Dec 15, 2023
1 parent 41fc593 commit cb26dc7
Show file tree
Hide file tree
Showing 3 changed files with 11,195 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release-on-push-to-mainline.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
node-version: [16.x, 18.x, 20.x]
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down
Loading

3 comments on commit cb26dc7

@trevor-scheer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettstack dropping support for node versions is technically a breaking change. Would you reconsider this change as a part of v5 instead? I understand Node v14 is EOL and not all projects consider this a major.

Apollo Server 4 still supports Node 14 (and runs our tests against it in CI), so we can't take the latest patch that introduced this restriction without dropping Node v14 testing (which we will do in a major).
apollographql/apollo-server#7804

@brettstack
Copy link
Collaborator Author

@brettstack brettstack commented on cb26dc7 Dec 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @trevor-scheer 14.x should still work, there are just issues with CI since updating dependencies to latest. Let me know if this isn't the case. I'll look into getting 14.x back into CI. 🙂

Edit: I see, it wasn't just removing from CI, I also updated package.json. I'll fix that ASAP

@trevor-scheer
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brettstack thanks for the quick turnaround! You already fixed a problem for someone before I even got to respond to them 😄
apollographql/apollo-server#7806

Please sign in to comment.