Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created component for Vacc form #252

Merged
merged 2 commits into from
Mar 8, 2021

Conversation

blakenan-bellese
Copy link
Contributor

Description

Created new Vaccination form that replaces existing Covid Form.

Related PRs

None

Related Issues

Resolves issue #250

List related Issues:

link
#250

@blakenan-bellese
Copy link
Contributor Author

blakenan-bellese commented Feb 25, 2021

@revjtanton I submitted this PR as draft because I wanted to get your feedback on the code change in Factility.vue that I made to get this new questionnaire to display. Seemed inelegant to me...

I expect that the questions themselves will change. At that time, I revise them and make this an official, non-draft PR.

Revised based on city feedback
@blakenan-bellese
Copy link
Contributor Author

The form is now ready for use based on feedback from city health department, removing draft label.

@blakenan-bellese blakenan-bellese marked this pull request as ready for review March 5, 2021 21:09
Copy link
Member

@funkybunch funkybunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! @blakenan-bellese this is intended to replace the existing form, correct?

@blakenan-bellese
Copy link
Contributor Author

@funkybunch Yup, replace the existing form.

@blakenan-bellese blakenan-bellese merged commit 0ceb406 into master Mar 8, 2021
@blakenan-bellese blakenan-bellese deleted the blakenan/issue-250-vacc-questions branch March 8, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants