fixed minor grammatical and spelling mistakes #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ram81 Please review the PR. |
Ram81
requested changes
Dec 8, 2018
|
|
||
| * Under ``` Social Accounts ```, open ``` Social applications ``` and click on ``` Add Social Application ```. | ||
|
|
||
| * Choose the ``` Provider ``` of social application as ``` Github ``` and name it ``` Github ```. | ||
| * Choose the ``` Provider ``` of the social application as ``` Github ``` and name it ``` Github ```. |
|
|
||
| * Under ```Social Accounts``` open ``` Social applications ```, click on ``` Add Social Application ```. | ||
|
|
||
| * Choose the ``` Provider ``` of social application as ``` Github ``` & name it ``` Github ```. | ||
| * Choose the ``` Provider ``` of the social application as ``` Github ``` & name it ``` Github ```. |
| @@ -1,15 +1,15 @@ | |||
| # Research about adding support for exporting model graphs from Fabrik | |||
| Attached code requires [common dependencies](../../requirements/common.txt), plus `networkx` and `pydot` Python packages. | |||
| ## Problem | |||
| Currently there's no tools for drawing Fabrik neural network diagram directly, without need to do it by hand. This research observes some ways to implement such function. | |||
| Currently, there are no tools for drawing Fabrik neural network diagram directly, without the need to do it by hand. This research observes some ways to implement such function. | |||
|
|
||
| Note that all tools can implemented with algorithms of conversion Fabrik net to framework model directly, without creating model files. | ||
| Note that all tools can implement with algorithms of conversion Fabrik net to framework model directly, without creating model files. |
| #### Implementing using JSON representation | ||
| If we dig inside Fabrik a little deeper, we find out that Fabrik stores neural network inside state as JS object. There are obtained sample net representation in `state_net.json`. It's Lenet MNIST with some layers deleted. | ||
|
|
||
| The only step to do is to draw graph based on this data. There are lots of ways, including [NN-SVG](https://github.com/zfrenchee/NN-SVG). Also a lot of different [JS libraries](https://stackoverflow.com/questions/7034/graph-visualization-library-in-javascript) and [other tools](https://www.quora.com/What-tools-are-good-for-drawing-neural-network-architecture-diagrams). In order to keep it simple, I created `draw_graph.py` that outputs pictured neural network with layer types and shapes. It uses [networkx](https://networkx.github.io/) for storing graph and pydot for visualisation, so it looks like Caffe's and Keras' network diagrams. | ||
| The only step to do is to draw a graph based on this data. There are lots of ways, including [NN-SVG](https://github.com/zfrenchee/NN-SVG). Also a lot of different [JS libraries](https://stackoverflow.com/questions/7034/graph-visualization-library-in-javascript) and [other tools](https://www.quora.com/What-tools-are-good-for-drawing-neural-network-architecture-diagrams). In order to keep it simple, I created `draw_graph.py` that outputs pictured neural network with layer types and shapes. It uses [networkx](https://networkx.github.io/) for storing graph and pydot for visualization, so it looks like Caffe's and Keras' network diagrams. |
| @@ -12,7 +12,7 @@ Frontend Design | |||
| * layerId | |||
| * ```changeHoveredLayer``` - changes which layer has the hover class on it, which outlines layer to emphasize a "hover" | |||
| * layerId | |||
| * ```modifyLayer``` - modifies layer, passed in layer is the new layer, and layer id is the id it needs to be replaced at. | |||
| * ```modifyLayer``` - modifies a layer, passed in the layer is the new layer, and layer id is the id it needs to be replaced at. | |||
| @@ -28,7 +28,7 @@ Frontend Design | |||
| * ```loadLayerShapes``` - AJAXs to backend to model parameters | |||
| * ```exportNet``` - AJAXs to backend and then passes back error/success | |||
| * framework | |||
| * ```importNet``` - AJAXs to backend and then passes back error/success | |||
| * ```importNet``` - AJAXs to the backend and then passes back error/success | |||
| @@ -110,14 +110,14 @@ If it does, it will return the direction the line needs to be shifted to the par | |||
| ```pane.js``` invokes ```paneElement.js``` to render out each element. | |||
| ```toggleClass``` toggles classes for the dropdown on the sidebar for layer selection. | |||
| ### ```paneElement.js``` | |||
| ```paneElement.js``` renders out each element of the pane, it is invoked by ```pane.js``` | |||
| ```paneElement.js``` render out each element of the pane, it is invoked by ```pane.js``` | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT NOTES (please read and then delete):
The PR title should start with "Fix #bugnum: " (if applicable), followed by a clear one-line present-tense summary of the changes introduced in the PR. For example: "Fix #bugnum: Changed UI layout from horizontal to vertical.".
Please make sure to mention "#bugnum" somewhere in the description of the PR. This enables Github to link the PR to the corresponding bug.
Please also make sure to follow the contribution guidelines.