Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard #477

Open
wants to merge 48 commits into
base: user-dashboard
Choose a base branch
from
Open

Dashboard #477

wants to merge 48 commits into from

Conversation

sayamkanwar
Copy link

Hi,
I have implemented the dashboard's design and functionality.
Details: #471
Please review @Ram81 @RishabhJain2018
Thank you! :)

@Ram81
Copy link
Member

Ram81 commented Nov 27, 2018

@sayamkanwar give me some time I'll go through the code.

Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayamkanwar most of the changes in PR are style changes, can you revert the style changes and remove flake8 ignore

ide/urls.py Outdated
@@ -1,9 +1,12 @@
# flake8: noqa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this and fix the style issues properly

ide/views.py Outdated
@@ -1,3 +1,4 @@
# flake8: noqa
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@@ -24,38 +26,67 @@ def fetch_layer_shape(request):
net[layerId]['shape'] = {}
net[layerId]['shape']['input'] = None
net[layerId]['shape']['output'] = None
dataLayers = ['ImageData', 'Data', 'HDF5Data', 'Input', 'WindowData', 'MemoryData', 'DummyData']
dataLayers = [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this

if (net[layerId]['info']['type'] in dataLayers):

if net[layerId]['info']['type'] in dataLayers:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove newline

return JsonResponse({
'result': 'error', 'error': str(sys.exc_info()[1])})
return JsonResponse({'result': 'error',
'error': str(sys.exc_info()[1])})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this style changes

ide/views.py Outdated
return JsonResponse({'result': 'error', 'error': str(sys.exc_info()[1])})

if Network.objects.filter(name=net_name).exists():

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove newline

ide/views.py Outdated
if Network.objects.filter(name=net_name).exists():

# Update the exising json field

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove newline

@sayamkanwar
Copy link
Author

Sure @Ram81!
Will do.

Copy link
Member

@Ram81 Ram81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayamkanwar also fix the webpack errors

@Ram81 Ram81 mentioned this pull request Dec 10, 2018
@Ram81
Copy link
Member

Ram81 commented Dec 10, 2018

@sayamkanwar can you please fix the issues you mentioned in #496

@sayamkanwar
Copy link
Author

@Ram81, I have answered all your questions in #496, please have a look at that.

@sayamkanwar
Copy link
Author

@Ram81, fixed all the style issues and webpack errors and fixed the issue I mentioned in #496.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants