-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #317: Added feature for multiple deletion of layers #329
base: master
Are you sure you want to change the base?
Fix #317: Added feature for multiple deletion of layers #329
Conversation
@Shivanshmundra can you share a screenshot? |
@Ram81 Is this what you wanted? |
@utsavgarg does this design for deleting multiple layers looks good to you? |
My two cents would be that, as mentioned in #317, I think a "delete mode" button in the actions tab would be a bit neater. |
@thatbrguy I didn't understand clearly what you said #317, like adding a delete mode and then selecting the layers to delete.I think above solution does that just in another way if I am getting you right. |
@Shivanshmundra Delete multiple layers is not a functionality of layer, you can provide a delete multiple layer button in zoo tab under some tab say 'Action' which will allow user to choose multiple layers and then use a delete action to delete all of them at once. |
@Shivanshmundra Thanks for the effort. The choice of placing the delete multiple layer button in each layer pane is a bit odd to me. Also, when deleting a layer, we need to take care of the parameter calculation, you could discuss this further with @Ram81. I tried to test it in its current state and it doesn't seem to function for a couple of models I imported from the model zoo. |
I thought of the same approach as @Shivanshmundra did. Isn't it easier to implement a multiple delete button rather than a delete mode button ? What changes are needed to this ? |
@yashdusing the delete key approach is better from user perspective. |
@Shivanshmundra @yashdusing If both of you want to pursue it, one of you can work on using the delete key for multiple layers, the other can move the delete button to the actions bar. Sorry for the confusion by calling it "delete mode". We just wanted it to be moved where it's common to all layers (Like the actions bar). The code for parameter count update should be available for single layer deletion, be sure to call it wherever necessary. |
Fix #317: Added feature for multiple deletion of layers
I added two buttons to include this feature:
I am working on the issue of stopping navigation drawer while layers are selected.