Stop evaluating booleans #2614
Closed
Stop evaluating booleans #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2614 +/- ##
==========================================
- Coverage 73.21% 73.14% -0.07%
==========================================
Files 82 82
Lines 5338 5347 +9
==========================================
+ Hits 3908 3911 +3
- Misses 1430 1436 +6
Continue to review full report at Codecov.
|
RishabhJain2018
requested changes
Feb 29, 2020
| @@ -696,7 +696,7 @@ def main(): | |||
| q_params["pk"] = challenge_pk | |||
|
|
|||
| if settings.DEBUG or settings.TEST: | |||
| if eval(LIMIT_CONCURRENT_SUBMISSION_PROCESSING): | |||
| if LIMIT_CONCURRENT_SUBMISSION_PROCESSING: | |||
There was a problem hiding this comment.
@drepram Why do we need to remove this?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed as there is no further activity. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the fix of the problem that has occurred on EvalAI-ngx, particularly Cloud-CV/EvalAI-ngx#249.
The changes I've proposed removed the evaluation though I've not been able to resolve the angular-devkit issue.
Here are the things that I've read and have tried:
akveo/ngx-admin#2138
https://stackoverflow.com/questions/56393158/errors-data-path-buildersapp-shell-should-have-required-property-class
https://stackoverflow.com/questions/56542518/schema-validation-failed-with-the-following-errors-data-path-buildersapp-sh/56624167
https://stackoverflow.com/questions/56506473/ionic-problem-ngschema-validation-failed-with-the-following-errorsngdata-p/56537342#56537342
bpmn-io/bpmn-js-example-angular#15
Perhaps someone else can give me some insight on how I can resolve this issue?