Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Inconsistency in the tabs shown to host and participants #312

Merged

Conversation

Kajol-Kumari
Copy link
Member

@Kajol-Kumari Kajol-Kumari commented Mar 30, 2020

Bug Fix [Inconsistency in the tabs shown to host and participants]

Bug description
The view_all_submission tab along with close participation button is visible to any normal user which should only be visible to the host of that challenge.

GIF of issue:
ezgif com-video-to-gif

GIF after Fix:
ezgif com-video-to-gif (1)

@codecov-io
Copy link

Codecov Report

Merging #312 into master will decrease coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
- Coverage   50.62%   50.57%   -0.06%     
==========================================
  Files          66       66              
  Lines        3771     3771              
  Branches      444      444              
==========================================
- Hits         1909     1907       -2     
- Misses       1767     1772       +5     
+ Partials       95       92       -3     
Impacted Files Coverage Δ
...bmissions/challengeviewallsubmissions.component.ts 30.28% <0.00%> (-1.45%) ⬇️
...bliclists/challengelist/challengelist.component.ts 47.57% <0.00%> (+0.97%) ⬆️
Impacted Files Coverage Δ
...bmissions/challengeviewallsubmissions.component.ts 30.28% <0.00%> (-1.45%) ⬇️
...bliclists/challengelist/challengelist.component.ts 47.57% <0.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3d23ca...b9f8d71. Read the comment docs.

@RishabhJain2018
Copy link
Member

@lunayach Can you please test and review this?

@deshraj deshraj requested a review from lunayach May 20, 2020 08:59
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #312 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #312      +/-   ##
==========================================
+ Coverage   50.38%   50.39%   +0.01%     
==========================================
  Files          66       66              
  Lines        3805     3806       +1     
  Branches      449      449              
==========================================
+ Hits         1917     1918       +1     
  Misses       1793     1793              
  Partials       95       95              
Impacted Files Coverage Δ
src/app/services/challenge.service.ts 47.13% <100.00%> (+0.97%) ⬆️
...bliclists/challengelist/challengelist.component.ts 44.34% <0.00%> (-0.87%) ⬇️
Impacted Files Coverage Δ
src/app/services/challenge.service.ts 47.13% <100.00%> (+0.97%) ⬆️
...bliclists/challengelist/challengelist.component.ts 44.34% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada5b64...65f9135. Read the comment docs.

Copy link
Member

@Sanji515 Sanji515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kajol-Kumari It's still not working for seeded challenges.

@Kajol-Kumari
Copy link
Member Author

Kajol-Kumari commented May 30, 2020

@Kajol-Kumari It's still not working for seeded challenges.

@Sanji515 can you please specify what's not working? As the the issue of view_all_submission tab has been already resolved after i added the participant privileges to the seeded challenge. I am updating this PR description. please take a look at it.

@Kajol-Kumari Kajol-Kumari changed the title Fixed view all submission tab under host setting Inconsistency in the tabs shown to host and participants May 30, 2020
@RishabhJain2018 RishabhJain2018 merged commit 027e748 into Cloud-CV:master May 30, 2020
@Kajol-Kumari Kajol-Kumari deleted the fix_view_all_submissions branch May 31, 2020 06:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants