-
Notifications
You must be signed in to change notification settings - Fork 61
Inconsistency in the tabs shown to host and participants #312
Inconsistency in the tabs shown to host and participants #312
Conversation
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 50.62% 50.57% -0.06%
==========================================
Files 66 66
Lines 3771 3771
Branches 444 444
==========================================
- Hits 1909 1907 -2
- Misses 1767 1772 +5
+ Partials 95 92 -3
Continue to review full report at Codecov.
|
...pp/components/challenge/challengeviewallsubmissions/challengeviewallsubmissions.component.ts
Outdated
Show resolved
Hide resolved
@lunayach Can you please test and review this? |
Codecov Report
@@ Coverage Diff @@
## master #312 +/- ##
==========================================
+ Coverage 50.38% 50.39% +0.01%
==========================================
Files 66 66
Lines 3805 3806 +1
Branches 449 449
==========================================
+ Hits 1917 1918 +1
Misses 1793 1793
Partials 95 95
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kajol-Kumari It's still not working for seeded challenges.
@Sanji515 can you please specify what's not working? As the the issue of |
Bug Fix [Inconsistency in the tabs shown to host and participants]
Bug description
The
view_all_submission
tab along withclose participation
button is visible to any normal user which should only be visible to the host of that challenge.GIF of issue:
GIF after Fix: