This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
Unit tests written for Improving the Coverage #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
===========================================
+ Coverage 50.62% 65.20% +14.58%
===========================================
Files 66 66
Lines 3771 3771
Branches 444 444
===========================================
+ Hits 1909 2459 +550
+ Misses 1767 1186 -581
- Partials 95 126 +31
Continue to review full report at Codecov.
|
|
@Sanji515 SIr, Can you please take a look at the unit tests i have written. I am not sure whether i am doing it correctly or not as i am just a begineer in writing tests. If it's fine i'll continue writing tests for the other services and components and if not then i will work on improving the tests i have written till now. |
Kajol-Kumari
changed the title
RishabhJain2018
approved these changes
May 20, 2020
Codecov Report
@@ Coverage Diff @@
## master #295 +/- ##
===========================================
+ Coverage 50.16% 64.47% +14.30%
===========================================
Files 66 66
Lines 3873 3873
Branches 450 450
===========================================
+ Hits 1943 2497 +554
+ Misses 1836 1251 -585
- Partials 94 125 +31
Continue to review full report at Codecov.
|
lunayach
reviewed
May 21, 2020
| @@ -53,4 +53,12 @@ describe('AnalyticsComponent', () => { | |||
| it('should create', () => { | |||
| expect(component).toBeTruthy(); | |||
| }); | |||
|
|
|||
| it('should call ngOninit', () => { | |||
There was a problem hiding this comment.
Is it possible to test more lines than the trivial component cases?
lunayach
reviewed
May 21, 2020
| expect(service.getUrl).toHaveBeenCalled(); | ||
| expect(service3.teamCountAnalyticsURL).toHaveBeenCalled(); | ||
| })); | ||
| it('should show download challenge participant team', inject([EndpointsService, ApiService], |
There was a problem hiding this comment.
Suggested change
| it('should show download challenge participant team', inject([EndpointsService, ApiService], | |
| it('should download challenge participant team', inject([EndpointsService, ApiService], |
lunayach
reviewed
May 21, 2020
lunayach
reviewed
May 21, 2020
| expect(endpointsService.updateChallengePhaseDetailsURL(2, 3)).toBe('challenges/challenge/2/challenge_phase/3'); | ||
| }); | ||
| it('should return challenge phase split url' , () => { | ||
| expect(endpointsService.challengePhaseSplitURL(2)).toBe('challenges/2/challenge_phase_split'); |
There was a problem hiding this comment.
Whenever possible, try not to hardcode URLs. Make them variables at the top and use them.
lunayach
suggested changes
May 21, 2020
There was a problem hiding this comment.
Overall, great job @Kajol-Kumari! At some places, I felt more lines in the code could be tested and we might boost the test coverage a little more. Since this is not the top priority for now, you could add more tests a little later when you can.
Kajol-Kumari
force-pushed
the
improve_coverage_ngx
branch
from
2bf4cb0
to
d59fe7d
Compare
|
@Kajol-Kumari Can you please check why the build is failing here? |
…improve_coverage_ngx
Kajol-Kumari
force-pushed
the
improve_coverage_ngx
branch
from
68805ee
to
3dcb306
Compare
…improve_coverage_ngx
Kajol-Kumari
force-pushed
the
improve_coverage_ngx
branch
from
9d4a90a
to
28f265f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feat: #85
Feature: Unit Tests for written for improving coverage for following files: