This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 61
Auth guards #282
Open
jayaike
wants to merge
10
commits into
Cloud-CV:master
Choose a base branch
from
jayaike:auth-guards
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Auth guards #282
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d1d2d34
Created TECHNIQUES_TO_PULL_DATA_FROM_EVALAI.md
jayaike 3a6dbbb
Merge branch 'master' into master
jayaike 4157798
Merge branch 'master' into master
jayaike 04b19b5
Delete TECHNIQUES_TO_PULL_DATA_FROM_EVALAI.md
jayaike a74e917
Added auth guards
jayaike 423879d
Removed unnecessary imports
jayaike dc6cc4c
Merge branch 'master' into auth-guards
jayaike 9981e01
Merge branch 'auth-guards' of https://github.com/nsjcorps/EvalAI-ngx …
jayaike 5a6c62b
Added auth guard for dashboard
jayaike 02a743f
Fixed errors
jayaike File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
import { Injectable } from '@angular/core'; | ||
import { Observable } from 'rxjs'; | ||
import { CanActivate, Router, UrlTree } from '@angular/router'; | ||
import { AuthService } from '../services/auth.service'; | ||
|
||
@Injectable() | ||
export class AuthGuard implements CanActivate { | ||
constructor(private authService: AuthService, private router: Router) {} | ||
|
||
canActivate(): Observable<boolean> | Promise<boolean> | boolean | UrlTree { | ||
const routePath = '/auth/login'; | ||
const isAuthenticated = this.authService.isLoggedIn(); | ||
|
||
if (isAuthenticated) { | ||
return true; | ||
} | ||
|
||
const tree: UrlTree = this.router.parseUrl(routePath); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure how this will help. I think Isn't it we can do this as well simply:
? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can't because it will behave the same way as above There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Check out the GIF in the PR description. You will see the difference |
||
return tree; | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have a better name: Authentication/authorization?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is normal convention
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sanji515