Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Fix #250 Fixed typo #258

Closed
wants to merge 4 commits into from
Closed

Conversation

Suryansh5545
Copy link
Member

#250
Fixed the small typo which was making list unreadable Reported by @nikochiko.
Selection_022

@codecov-io
Copy link

codecov-io commented Jan 5, 2020

Codecov Report

Merging #258 into master will decrease coverage by 0.01%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
- Coverage   50.66%   50.64%   -0.02%     
==========================================
  Files          66       66              
  Lines        3766     3771       +5     
  Branches      442      444       +2     
==========================================
+ Hits         1908     1910       +2     
- Misses       1763     1766       +3     
  Partials       95       95
Impacted Files Coverage Δ
...rc/app/components/challenge/challenge.component.ts 87.85% <100%> (ø) ⬆️
...e/challengesettings/challengesettings.component.ts 45.16% <33.33%> (-0.46%) ⬇️
Impacted Files Coverage Δ
...rc/app/components/challenge/challenge.component.ts 87.85% <100%> (ø) ⬆️
...e/challengesettings/challengesettings.component.ts 45.16% <33.33%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321412d...62ee0a2. Read the comment docs.

@nikochiko
Copy link

@Suryansh5545 Thanks for the fix! Looks great :D

But please try to ask on the issue before opening up the PRs. I had mentioned in the issue that

P.S. I would like to make a quick fix for this.

@Suryansh5545
Copy link
Member Author

Sorry i forgot it i will close this pr

@nikochiko
Copy link

@Suryansh5545 No no, it's totally alright! Let it be there.
I just meant you could tell on the issue that you want to work, so we both wouldn't be working on the same issue. It's alright 😄

@Suryansh5545 Suryansh5545 reopened this Jan 5, 2020
@Suryansh5545
Copy link
Member Author

Thx @nikochiko for understanding.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants