Modify the challenge leaderboard page

[Sanji515]

Changes proposed in this pull request:

• Modified the challenge leadeboard page, changed the url by appending the phase split id and by default setted the top phase split id in the url

• Link to live demo: http://pr-154-evalai.surge.sh

Screenshot 1:

Screenshot 2:

[RishabhJain2018]

@Sanji515 Please resolve the conflicts here.

[codecov-io]

Codecov Report

Merging #155 into master will decrease coverage by 0.16%.
The diff coverage is 28.2%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage    52.3%   52.14%   -0.17%     
==========================================
  Files          63       63              
  Lines        3361     3404      +43     
  Branches      383      384       +1     
==========================================
+ Hits         1758     1775      +17     
- Misses       1510     1535      +25     
- Partials       93       94       +1

Impacted Files	Coverage Δ
...lengesubmissions/challengesubmissions.component.ts	35.39% <100%> (+0.36%)	⬆️
...lenge/challengesubmit/challengesubmit.component.ts	31.72% <100%> (+0.36%)	⬆️
...bmissions/challengeviewallsubmissions.component.ts	30.73% <100%> (+0.33%)	⬆️
...lengeleaderboard/challengeleaderboard.component.ts	34.14% <16.07%> (-0.64%)	⬇️
...nents/utility/selectphase/selectphase.component.ts	68.57% <50%> (-13.25%)	⬇️
src/app/services/api.service.ts	68.25% <60%> (-1.11%)	⬇️

Impacted Files	Coverage Δ
...lengesubmissions/challengesubmissions.component.ts	35.39% <100%> (+0.36%)	⬆️
...lenge/challengesubmit/challengesubmit.component.ts	31.72% <100%> (+0.36%)	⬆️
...bmissions/challengeviewallsubmissions.component.ts	30.73% <100%> (+0.33%)	⬆️
...lengeleaderboard/challengeleaderboard.component.ts	34.14% <16.07%> (-0.64%)	⬇️
...nents/utility/selectphase/selectphase.component.ts	68.57% <50%> (-13.25%)	⬇️
src/app/services/api.service.ts	68.25% <60%> (-1.11%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9b70c...aa30af5. Read the comment docs.

[lunayach]

@RishabhJain2018 it works fine except when we click on Page is Outdated, Click to Update button , Last Submission at disappears. I discussed, this with @Sanji515, he said this worked fine before that Worker issue in ngx when he had created it. Now, he cannot test this because the Worker is failing.

[RishabhJain2018]

I've opened the PR for the worker fix. @Sanji515 Please take a look at that and then test it.

[Sanji515]

@RishabhJain2018 @lunayach Resolved all the comments and tested the functionality, it's working perfectly on my side. Please review 😃

[lunayach]

Hi @Sanji515, I was referring to this issue. When I click on the update button, the Last Submission at disappears. (Using EvalAI's backend while doing ng serve.)

[RishabhJain2018]

@Sanji515 The issue mentioned by Mayank is fixed, right?

[lunayach]

@Sanji515 The issue mentioned by Mayank is fixed, right?

The issue is resolved now. Thanks, @Sanji515.

[lunayach]

@Sanji515 can you also refer this file in #171?

[Sanji515]

sure, thanks 👍

[lunayach]

This looks good to be merged now.
Two points:

• Currently, the "Page is Outdated, Click to update" button appears only when the no. of submissions for that particular phase and split has changed. But what if the host re-runs the submission of the user(s). I think an additional check for this should also be included.
• The toggle button, Show on Leaderboard does not seem to be rendering properly.
  

@Sanji515 @RishabhJain2018 should we create issues to take care of the above points later. (IDK, maybe the second point could be addressed in this PR itself.)

[RishabhJain2018]

@Sanji515 Can you please take care of both the things in a separate PR?