This repository has been archived by the owner on Jul 6, 2020. It is now read-only.
fix: Fix Endpoint Service not being injected in self object #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR fixes 116 issue. |
Codecov Report
@@ Coverage Diff @@
## master #117 +/- ##
==========================================
+ Coverage 53.39% 53.43% +0.03%
==========================================
Files 55 55
Lines 2358 2360 +2
Branches 253 253
==========================================
+ Hits 1259 1261 +2
Misses 1025 1025
Partials 74 74
Continue to review full report at Codecov.
|
2 tasks
|
Nice find. Shall we merge this @Shekharrajak @RishabhJain2018? |
|
Yes! I believe it can be merged, after another approval. |
RishabhJain2018
approved these changes
May 9, 2019
sanketbansal
pushed a commit
to sanketbansal/EvalAI-ngx
that referenced
this pull request
May 18, 2019
…#117) * Endpoint Service was not being injected in self object * Add Endpoint service in test file providers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 116
Changes proposed in this pull request: