-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logger examples in eval script #59
base: master
Are you sure you want to change the base?
Conversation
@@ -62,6 +62,22 @@ If you are looking for a simple challenge configuration that you can replicate t | |||
|
|||
11. To update the challenge on EvalAI, make changes in the repository and push on `challenge` branch and wait for the build to complete. | |||
|
|||
### Printing and Logging in Evaluation Script |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to Logging in Evaluation Script
eval_script_logger = logging.getLogger(name='eval_script') | ||
eval_script_logger.setLevel(logging.DEBUG) | ||
|
||
handler = logging.StreamHandler(sys.stdout) | ||
handler.setLevel(logging.DEBUG) | ||
formatter = logging.Formatter('%(asctime)s - %(name)s - %(levelname)s - %(message)s') | ||
handler.setFormatter(formatter) | ||
eval_script_logger.addHandler(handler) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you create a new method called get_logger
in this script and use that to get the logger here?
### Printing and Logging in Evaluation Script | ||
`print` statements will show up on the console directly. | ||
In order to get `logging` statements from the evaluation script, ensure that the logger has a `stdout` handler added. We redirect the output from `stdout` to the submission workers console. | ||
An example logger can be created like so: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to Here's an example of setting up a logger:
eval_script_logger.addHandler(handler) | ||
``` | ||
|
||
Then, we can use this logger anywhere in the script and the corresponding level logs will show up in the output. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chnage to Once set up, you can use the logger anywhere in the evaluation script to display logs on EvalAI manage tab.
This PR adds examples for logger in evaluation script and adds some suggestions in the README.