-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and CI rework #35
Closed
Closed
Commits on Mar 22, 2019
-
promu is useless in Makefile because it builds but we already do `go install`.
Configuration menu - View commit details
-
Copy full SHA for cebd6fa - Browse repository at this point
Copy the full SHA cebd6faView commit details -
Current CI configuration uses outdated Ubuntu Trusty and unsupported Go versions. This change updates version to Ubuntu Xenial and latest (at the moment of commit) supported versions of Go.
Configuration menu - View commit details
-
Copy full SHA for 51c3bf6 - Browse repository at this point
Copy the full SHA 51c3bf6View commit details -
Currently `go test` is running in "local directory mode". Citing the `go help test`: > The first, called local directory mode, occurs when go test is invoked with no package arguments (for example, 'go test' or 'go test -v'). In this mode, go test compiles the package sources and tests found in the current directory and then runs the resulting test binary. So no actual tests are run because main package doesn't have any. This commit adds testing of all packages by adding `./...` argument to test command. It also adds spinning up docker-compose to make tests pass because the tests need to query real Clickhouse instance.
Configuration menu - View commit details
-
Copy full SHA for 10ff101 - Browse repository at this point
Copy the full SHA 10ff101View commit details -
goreleaser is used for making GitHub releases on tag push so people could download the prebuilt binaries and Linux packages. goreleaser will create GitHub release with: * Binaries for Linux and Darwin for amd64 and i386 * Deb and RPM packages for amd64 and i386
Configuration menu - View commit details
-
Copy full SHA for 4baa178 - Browse repository at this point
Copy the full SHA 4baa178View commit details -
Add release creation on tag push
Travis CI will invoke goreleaser on tag push that will create GitHub release with artifacts described in goreleaser config.
Configuration menu - View commit details
-
Copy full SHA for 307ad92 - Browse repository at this point
Copy the full SHA 307ad92View commit details
Commits on Mar 25, 2019
-
Fix deploy condition in Travis CI
To avoid deploy job failure we have to invoke goreleaser from one job because otherwise GitHub release is already created. In this commit we add second condition to deploy with the last Go version.
Configuration menu - View commit details
-
Copy full SHA for 4a3fe48 - Browse repository at this point
Copy the full SHA 4a3fe48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b14a23 - Browse repository at this point
Copy the full SHA 2b14a23View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.