-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update zlib-ng from 2.0.2 to 2.1.7 #64489
Conversation
This is an automated comment for commit 8703941 with description of existing statuses. It's updated for the latest CI running ✅ Click here to open a full report in a separate page Successful checks
|
PPC and FreeBSD builds are broken. Side note and not blocking this PR: our zlib-ng fork, in particular branch |
New contrib update PR: ClickHouse/zlib-ng#17 that cherry-picks our patches onto a clean upstream. This PR points to that now. |
Waiting on ClickHouse/zlib-ng#18 , plz review. |
Kind of unrelated to this PR: I count > 10 custom patches in zlib, going back to 2021. Sounds odd to me, we should contribute them back to upstream instead of dragging them from update to update ... |
Changelog category (leave one):
Fixes #63319
ClickHouse/zlib-ng#17 should be merged first
The actual fix appears to be zlib-ng/zlib-ng#1071 - it simplifies the compressed-size-upper-bound estimate to stop trying to be clever and tight (the bug was that it was underestimated), and just overestimates by ~14%. Instead of cherry-picking it, this PR updates the whole library because I assume that's better (?). (From resolving conflicts I got the impression that there was some reasonable cleanup refactoring done there, so I'm guessing this library has not peaked yet!)