Fixed wrong "spoils_in" value for some food (fixes #70297) #74898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2018 "spoils_in" values has been converted from integer (hours) to strings like (X months Y days). commit: 25e35c9 Seems like convertion was automated and 1008 was replaced with "24 days" in every instance. But 1008 hours is actuallly 42 days, which seem very likely to be a typo. Those values have been reviewed in CleverRaven#23986 where 1008 hours has been set.
github-actions
bot
added
new contributor
[JSON]
|
I beg you to tell me what is wrong with description that PR validator fails. I clearly have no idea |
I've fixed it but when you deleted all of the template, you deleted the instructions on how to make a non failing PR title :) |
|
Oh, thanks a lot 🙂 My bad. Sorry for that |
github-actions
bot
added
the
BasicBuildPassed
No stress. I'd have merged this by now but I found an issue with bacon that I want to resolve one way or another before I merge this and forget about it. |
|
Okay 🙂 thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Changes some spoils in times"
Purpose of change
In 2018 "spoils_in" values has been converted from integer (hours) to strings like (X months Y days).
commit: 25e35c9. Fixes #70297
Seems like conversion was automated and 1008 was replaced with "24 days" in every instance. But 1008 hours is actuallly 42 days, which seem very likely to be a typo.
Describe the solution
Changed "24 days" to "42 days"
Describe alternatives you've considered
None
Testing
This doesn't seem to need testing
Additional context
Those values have been reviewed in #23986 where 1008 hours has been set.